From 2a81c5d8cc7e0ced742cf5f1fb99b5df62b1bc01 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Mon, 28 Nov 2022 14:35:37 +0000 Subject: [PATCH] Bug 32221: Borrowers.password should no longer be an option When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice. Test plan: 1) Navigate to Tools > Notices and slips 2) Either create a new notice or edit an existing notice 3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password" 4) Apply patch 5) Navigate to the same menu 6) Observe that the "borrowers.password" option is now no longer visible Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 9608b16a6ba9d877dddc75beb1e1eef691f7b21a) Signed-off-by: Matt Blenkinsop (cherry picked from commit 7a143c19ad570adf8ab6cdf6f65a5456f7357ad3) Signed-off-by: Lucas Gass --- tools/letter.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/letter.pl b/tools/letter.pl index 4276e46280..8614c4dbfd 100755 --- a/tools/letter.pl +++ b/tools/letter.pl @@ -499,6 +499,7 @@ sub get_columns_for { my $rows = C4::Context->dbh->selectall_arrayref($sql, { Slice => {} }); for my $row (@{$rows}) { next if $row->{'Field'} eq 'timestamp'; # this is really an irrelevant field and there may be other common fields that should be excluded from the list + next if $row->{'Field'} eq 'password'; # passwords can no longer be shown in notices so the password field should be removed as a template option push @fields, { value => $table_prefix . $row->{Field}, text => $table_prefix . $row->{Field},