Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23425: (QA follow-up) Keep it generic

Browse source 
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomás Cohen Arazi 2019-09-17 15:08:06 -03:00 committed by Martin Renvoize
parent 5d3b46df3f
commit 2ae6e95a40
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
3 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Biblio/Metadata.pm
View file

@ -75,7 +75,7 @@ sub record {
id => $self->id,
format => $self->format,
schema => $self->schema,
marcxml_error => $marcxml_error,
decoding_error => $marcxml_error,
);
}
}

6
Koha/Exceptions/Metadata.pm
View file

@ -25,7 +25,7 @@ use Exception::Class (
'Koha::Exceptions::Metadata::Invalid' => {
isa => 'Koha::Exceptions::Metadata',
description => 'Invalid data',
fields => ['id','format','schema', 'marcxml_error']
fields => ['id','format','schema', 'decoding_error']
}
);
@ -36,8 +36,8 @@ sub full_message {
unless ($msg) {
if ( $self->isa('Koha::Exceptions::Metadata::Invalid') ) {
$msg = sprintf( "Invalid data, cannot decode object (id=%s, format=%s, schema=%s, MARCXML error='%s')",
$self->id, $self->format, $self->schema, $self->marcxml_error );
$msg = sprintf( "Invalid data, cannot decode object (id=%s, format=%s, schema=%s, decoding_error='%s')",
$self->id, $self->format, $self->schema, $self->decoding_error );
}
}

6
t/Koha/Exceptions.t
View file

@ -115,12 +115,14 @@ subtest 'Koha::Exceptions::Metadata tests' => sub {
$object->mock( 'schema', 'a_schema' );
throws_ok
{ Koha::Exceptions::Metadata::Invalid->throw( id => 'an_id', format => 'a_format', schema => 'a_schema' ); }
{ Koha::Exceptions::Metadata::Invalid->throw(
id => 'an_id', format => 'a_format',
schema => 'a_schema', decoding_error => 'a_nasty_error' ); }
'Koha::Exceptions::Metadata::Invalid',
'Exception is thrown :-D';
# stringify the exception
is( "$@", 'Invalid data, cannot decode object (id=an_id, format=a_format, schema=a_schema)', 'Exception stringified correctly' );
is( "$@", 'Invalid data, cannot decode object (id=an_id, format=a_format, schema=a_schema, decoding_error=\'a_nasty_error\')', 'Exception stringified correctly' );
throws_ok
{ Koha::Exceptions::Metadata::Invalid->throw( "Manual message exception" ) }