Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37076: Fix incorrect needsconfirmation code

Browse source 
This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING

Test plan:
1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO
2) Observe from the description that the correct status code is RESERVE_WAITING
3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js
4) Apply patch
5) Repeat step 3 - there should be 0 instances

Signed-off-by: Lucas <lchirlias@ville-roubaix.fr>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Matt Blenkinsop 2024-06-12 13:36:42 +00:00 committed by Katrin Fischer
parent ede0b6d8d7
commit 2b7e770429
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/REST/V1/Checkouts.pm
View file

@ -120,7 +120,7 @@ sub _check_availability {
# Upgrade some confirmations to blockers
my @should_block =
qw/TOO_MANY ISSUED_TO_ANOTHER RESERVED RESERVED_WAITING TRANSFERRED PROCESSING AGE_RESTRICTION/;
qw/TOO_MANY ISSUED_TO_ANOTHER RESERVED RESERVE_WAITING TRANSFERRED PROCESSING AGE_RESTRICTION/;
for my $block (@should_block) {
if ( exists( $confirmation->{$block} ) ) {
$impossible->{$block} = $confirmation->{$block};

2
koha-tmpl/opac-tmpl/bootstrap/js/modals/checkout.js
View file

@ -25,7 +25,7 @@ $(document).ready(function() {
result += _("Your account is currently in debt by '%s'").format(data);
} else if (code == 'ISSUED_TO_ANOTHER') {
result += _("This item appears to be checked out to another patron, please return it to the desk");
} else if (code == 'RESERVED' || code == 'RESERVED_WAITING') {
} else if (code == 'RESERVED' || code == 'RESERVE_WAITING') {
result += _("This item appears to be on hold for another patron, please return it to the desk");
} else if (code == 'TOO_MANY') {
result += _("You have reached the maximum number of checkouts allowed on your account");