Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t

Browse source 
A subest in t/db_dependent/Holds.t leaves behind database cruft.

Test Plan:
Using koha-testing-docker:
1) SELECT branchcode FROM branches
2) prove t/db_dependent/Holds.t
3) SELECT branchcode FROM branches
   Note cruft
4) reset_all
2) prove t/db_dependent/Holds.t
3) SELECT branchcode FROM branches
   No cruft!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Kyle Hall 2022-10-21 11:31:09 -04:00 committed by Tomas Cohen Arazi
parent 0d2f1aeaf9
commit 2b8b02a587
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
t/db_dependent/Holds.t
View file

@ -1709,6 +1709,9 @@ subtest 'ModReserve can only update expirationdate for found holds' => sub {
subtest 'Koha::Holds->get_items_that_can_fill returns items with datecancelled or (inclusive) datearrived' => sub {
plan tests => 8;
$schema->storage->txn_begin;
# biblio item with date arrived and date cancelled
my $biblio1 = $builder->build_sample_biblio();
my $item1 = $builder->build_sample_item({ biblionumber => $biblio1->biblionumber });
@ -1795,4 +1798,6 @@ subtest 'Koha::Holds->get_items_that_can_fill returns items with datecancelled o
is($items_that_can_fill3->count, 1, "Koha::Holds->get_items_that_can_fill returns 1 item with correct parameters");
is($items_that_can_fill4->next, undef, "Koha::Holds->get_items_that_can_fill doesn't return item with undefined datearrived and undefined datecancelled");
is($items_that_can_fill4->count, 0, "Koha::Holds->get_items_that_can_fill returns 0 item");
}
$schema->storage->txn_rollback;
};