Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 39188: Fix ESLint by Updating "globals" node package

Browse source 
According to the main dev of ESLint, we should add it to devDependencies
because we are the ones calling globals from eslint.config.mjs:
https://github.com/eslint/eslint/issues/19209#issuecomment-2518452107

Test plan:
1. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
2. TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace
3. :(
4. Apply patch
5. sudo yarn install --modules-folder /kohadevbox/node_modules
6. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
7. eslint output a report about the issues found in the file
8. signoff :D

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Victor Grousset 2025-02-24 05:41:50 +01:00 committed by Katrin Fischer
parent 45f8762c40
commit 2b9eb2be18
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
package.json
View file

@ -80,6 +80,7 @@
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-vue": "^9.29.0",
"globals": "^16.0.0",
"gulp-tap": "^1.0.1",
"html-webpack-plugin": "^5.5.0",
"node-sass-tilde-importer": "^1.0.2",