Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28152: Log the "duplicate item barcode" error

Browse source 
Looking at the code this 'import_error' column is empty for the last 9 years. Not sure it makes much sense to have this single error now.

commit 1dba9c6409
Date:   Wed Oct 10 14:21:22 2012 -0500
    Bug 7131: teach MARC import how to overlay items

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 3c0c375d8e)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2022-01-10 11:22:54 +01:00 committed by Lucas Gass
parent e5d97a001d
commit 2d19940f7e
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
C4/ImportBatch.pm
View file

@ -770,13 +770,14 @@ sub BatchCommitItems {
my $duplicate_barcode = exists( $item->{'barcode'} ) && Koha::Items->find({ barcode => $item->{'barcode'} });
my $duplicate_itemnumber = exists( $item->{'itemnumber'} );
my $updsth = $dbh->prepare("UPDATE import_items SET status = ?, itemnumber = ? WHERE import_items_id = ?");
my $updsth = $dbh->prepare("UPDATE import_items SET status = ?, itemnumber = ?, import_error = ? WHERE import_items_id = ?");
if ( $action eq "replace" && $duplicate_itemnumber ) {
# Duplicate itemnumbers have precedence, that way we can update barcodes by overlaying
ModItemFromMarc( $item_marc, $biblionumber, $item->{itemnumber} );
$updsth->bind_param( 1, 'imported' );
$updsth->bind_param( 2, $item->{itemnumber} );
$updsth->bind_param( 3, $row->{'import_items_id'} );
$updsth->bind_param( 3, undef );
$updsth->bind_param( 4, $row->{'import_items_id'} );
$updsth->execute();
$updsth->finish();
$num_items_replaced++;
@ -785,14 +786,16 @@ sub BatchCommitItems {
ModItemFromMarc( $item_marc, $biblionumber, $itemnumber );
$updsth->bind_param( 1, 'imported' );
$updsth->bind_param( 2, $item->{itemnumber} );
$updsth->bind_param( 3, $row->{'import_items_id'} );
$updsth->bind_param( 3, undef );
$updsth->bind_param( 4, $row->{'import_items_id'} );
$updsth->execute();
$updsth->finish();
$num_items_replaced++;
} elsif ($duplicate_barcode) {
$updsth->bind_param( 1, 'error' );
$updsth->bind_param( 2, undef );
$updsth->bind_param( 3, $row->{'import_items_id'} );
$updsth->bind_param( 3, 'duplicate item barcode' );
$updsth->bind_param( 4, $row->{'import_items_id'} );
$updsth->execute();
$num_items_errored++;
} else {
@ -804,7 +807,8 @@ sub BatchCommitItems {
if( $itemnumber ) {
$updsth->bind_param( 1, 'imported' );
$updsth->bind_param( 2, $itemnumber );
$updsth->bind_param( 3, $row->{'import_items_id'} );
$updsth->bind_param( 3, undef );
$updsth->bind_param( 4, $row->{'import_items_id'} );
$updsth->execute();
$updsth->finish();
$num_items_added++;