Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11889: (QA follow-up) Changes for wantarray move in ->search

Browse source 
See bug 29844.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2022-06-08 14:47:05 +00:00 committed by Tomas Cohen Arazi
parent 824352d503
commit 2eac11c24d
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Koha/Patron.pm
View file

@ -393,8 +393,8 @@ sub delete {
if ( C4::Context->preference('ListOwnershipUponPatronDeletion') eq 'transfer' ) {
my $userenv = C4::Context->userenv();
my $usernumber = (ref($userenv) eq 'HASH') ? $userenv->{'number'} : 0;
my @publiclists = Koha::Virtualshelves->get_public_shelves;
my @sharedlists = Koha::Virtualshelves->get_shared_shelves({ borrowernumber => $self->borrowernumber });
my @publiclists = Koha::Virtualshelves->get_public_shelves->as_list;
my @sharedlists = Koha::Virtualshelves->get_shared_shelves({ borrowernumber => $self->borrowernumber })->as_list;
foreach my $plist ( @publiclists ) {
if ( $plist->owner == $self->borrowernumber ) {
my $unique_name = $plist->shelfname . '_' . $self->borrowernumber;
@ -411,7 +411,7 @@ sub delete {
# Delete any remaining lists that this user is an owner of (always private lists,
# only public and shared lists if ListOwnershipUponPatronDeletion = delete)
$_->delete for Koha::Virtualshelves->search({ owner => $self->borrowernumber });
$_->delete for Koha::Virtualshelves->search({ owner => $self->borrowernumber })->as_list;
# We cannot have a FK on borrower_modifications.borrowernumber, the table is also used
# for patron selfreg