Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31112: (QA follow-up) Fetch patrons with reserves

Browse source 
Previously we fetched all in a single call using biblionumbers

Fetching each individually could be a performance hit on systems
with large numbers of holds

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2022-08-19 13:23:05 +00:00 committed by Tomas Cohen Arazi
parent 4676ce1a03
commit 2eb053603d
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
C4/Circulation.pm
View file

@ -2949,7 +2949,10 @@ sub CanBookBeRenewed {
)
{
my $biblio = Koha::Biblios->find($item->biblionumber);
my @possible_holds = $biblio->current_holds->unfilled->search({non_priority => 0})->as_list;
my @possible_holds = $biblio->current_holds->unfilled->search(
{non_priority => 0},
{ prefetch => 'patron' }
)->as_list;
# Get all other items that could possibly fill reserves
# FIXME We could join reserves (or more tables) here to eliminate some checks later