Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24313: Always display XSLT errors in logs

Browse source 
From
  commit 295ae33800
  Bug 20272: Replace error numbers by codes in XSLT_Handler

"""
    Make XSLT_Handler a little bit less noisy by defaulting print_warns to
    false unless $ENV{DEBUG} is set. (See also bug 19018).
"""

I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG.
If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard)

Test plan:
Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-12-27 14:55:36 +01:00 committed by Martin Renvoize
parent c121a53dd7
commit 3015fc1bae
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Koha/XSLT_Handler.pm
View file

@ -264,9 +264,7 @@ sub _init {
$self->_set_error;
$self->{xslt_hash} = {};
$self->{print_warns} = exists $self->{print_warns}
? $self->{print_warns}
: $ENV{DEBUG} // 0;
$self->{print_warns} = 1 unless exists $self->{print_warns};
$self->{do_not_return_source} = 0
unless exists $self->{do_not_return_source};