Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25670: Fix random failure on Orders.t

Browse source 
It has failed at least 3 times:

 #   Failed test 'The right order is returned'
 #   at t/db_dependent/Koha/Acquisition/Orders.t line 153.
 #          got: '50'
 #     expected: '49'

 #   Failed test 'The right order is returned'
 #   at t/db_dependent/Koha/Acquisition/Orders.t line 154.
 #          got: '49'
 #     expected: '50'
 # Looks like you failed 2 tests of 6.

I cannot manage to make it fail locally

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2021-02-01 10:35:12 +01:00
parent 1379cbb363
commit 3094bf9bad
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
t/db_dependent/Koha/Acquisition/Orders.t
View file

@ -121,7 +121,7 @@ subtest 'filter_by_active() tests' => sub {
subtest 'filter_by_id_including_transfers() tests' => sub {
plan tests => 6;
plan tests => 4;
$schema->storage->txn_begin;
@ -149,9 +149,7 @@ subtest 'filter_by_id_including_transfers() tests' => sub {
$orders_rs = $orders_rs->filter_by_id_including_transfers({ ordernumber => $order_1->ordernumber });
is( $orders_rs->count, 2, 'The two referenced orders are returned' );
is( $orders_rs->next->ordernumber, $order_1->ordernumber, 'The right order is returned' );
is( $orders_rs->next->ordernumber, $order_2->ordernumber, 'The right order is returned' );
is_deeply( [ sort $orders_rs->get_column('ordernumber') ], [$order_1->ordernumber, $order_2->ordernumber ], 'The 2 orders are returned' );
$orders_rs = $orders_rs->filter_by_id_including_transfers({ ordernumber => $order_2->ordernumber });