Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10727: Replace carriage return with <br /> when printing hold notices

Browse source 
This patch replaces carriage return with <br /> in the content of
hold notices for printing. This is necessary to convert html file
into well formatted pdf file.

Test plan :
  - check in an item reserved by a borrower
    that has not activated email notification
  - verify in message_queue table that you've got a
    new HOLD_PRINT notice with status 'pending'
  - run gather_print_notices.pl <directory>

Without the patch, the script generates a html file without <br /> tags.
If you run printoverdues.sh <directory>, the text in the resulting PDF
file is all on one line

With the patch, the script generates a html file with <br/> tags and
the PDF file created by printoverdues.sh is well formatted.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Sophie Meynieux 2013-08-14 15:51:10 +02:00 committed by Galen Charlton
parent 0c67e94c8b
commit 30b32d9938
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
misc/cronjobs/gather_print_notices.pl
View file

@ -69,6 +69,14 @@ my $today = C4::Dates->new();
my @all_messages = @{ GetPrintMessages() };
exit unless (@all_messages);
## carriage return replaced by <br/> as output is html
foreach my $message (@all_messages) {
local $_ = $message->{'content'};
s/\n/<br \/>/g;
s/\r//g;
$message->{'content'} = $_;
}
my $OUTPUT;
if ($split) {