Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18620: [QA Follow-up] Move the final rollback to the very end

Browse source 
The new subtest in Reserves.t does not need its own transaction.
Move the original rollback to the very end of the test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

https://bugs.koha-community.org/show_bug.cgi?id=18478

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2017-05-26 11:20:42 +02:00 committed by Kyle M Hall
parent 8f726ae06d
commit 30ca02aee8
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
t/db_dependent/Reserves.t
View file

@ -714,15 +714,10 @@ $cache->clear_from_cache("MarcStructure-1-$frameworkcode");
$cache->clear_from_cache("default_value_for_mod_marc-$frameworkcode");
$cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
# we reached the finish
$schema->storage->txn_rollback();
subtest '_koha_notify_reserve() tests' => sub {
plan tests => 2;
$schema->storage->txn_begin;
my $wants_hold_and_email = {
wants_digest => '0',
transports => {
@ -790,8 +785,6 @@ subtest '_koha_notify_reserve() tests' => sub {
})->next()->to_address();
is($email_message_address, undef ,"We should not populate the hold message with the email address, sending will do so");
$schema->storage->txn_rollback();
};
sub count_hold_print_messages {
@ -803,3 +796,6 @@ sub count_hold_print_messages {
});
return $message_count->[0]->[0];
}
# we reached the finish
$schema->storage->txn_rollback();