Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Fixes bug 5232: Shelfname won't display on high-numbered lists

Browse source 
This bugfix adds an explicit GetShelf for the specific shelfnumber when viewing that individual shelfnumber.  This captures the
shelfname, which was originally pulled from shelflist->{$shelfnumber}, which may not have been populated if the List in question was
beyond the 20th private or public list in the system.

Also adds a more explicit sort: the sort from the CGI takes top priority, then it falls back to the default sort for the list, and
ultimate falls to 'title' if neither CGI nor default sort exist.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Ian Walls 2010-11-30 02:25:30 -05:00 committed by Chris Cormack
parent b9ccc51841
commit 31439fc51a
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
C4/VirtualShelves/Page.pm
View file

@ -174,13 +174,22 @@ sub shelfpage ($$$$$) {
last SWITCH;
}
if ( $shelfnumber = $query->param('viewshelf') ) {
# explicitly fetch this shelf
my ($shelfnumber2,$shelfname,$owner,$category,$sorton) = GetShelf($shelfnumber);
#check that the user can view the shelf
if ( ShelfPossibleAction( $loggedinuser, $shelfnumber, 'view' ) ) {
my $items;
my $authorsort;
my $yearsort;
my $sortfield = ( $query->param('sortfield') ? $query->param('sortfield') : 'title' );
my $sortfield;
if ( $query->param('sortfield')) {
$sortfield = $query->param('sortfield');
} elsif ($sorton) {
$sortfield = $sorton;
} else {
$sortfield = 'title';
}
if ( $sortfield eq 'author' ) {
$authorsort = 'author';
}
@ -210,7 +219,7 @@ sub shelfpage ($$$$$) {
my $i = 0;
my $manageshelf = ShelfPossibleAction( $loggedinuser, $shelfnumber, 'manage' );
$template->param(
shelfname => $shelflist->{$shelfnumber}->{'shelfname'} || $privshelflist->{$shelfnumber}->{'shelfname'},
shelfname => $shelfname,
shelfnumber => $shelfnumber,
viewshelf => $shelfnumber,
authorsort => $authorsort,