From 328baf44b457bc34cd93ffad8128b79d4ee30a42 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 19 Jul 2023 15:20:46 +0100 Subject: [PATCH] Bug 34258: (QA follow-up) Tidy the test Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/SIP/ILS.t | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/t/db_dependent/SIP/ILS.t b/t/db_dependent/SIP/ILS.t index 10f4d28f68..3bc5f63146 100755 --- a/t/db_dependent/SIP/ILS.t +++ b/t/db_dependent/SIP/ILS.t @@ -318,8 +318,8 @@ subtest renew_all => sub { subtest renew => sub { plan tests => 2; - my $library = $builder->build_object ({ class => 'Koha::Libraries' }); - my $patron = $builder->build_object( + my $library = $builder->build_object( { class => 'Koha::Libraries' } ); + my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { @@ -327,17 +327,19 @@ subtest renew => sub { } } ); - t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode }); + t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode } ); - my $item = $builder->build_sample_item({ - library => $library->branchcode, - }); + my $item = $builder->build_sample_item( + { + library => $library->branchcode, + } + ); AddIssue( $patron->unblessed, $item->barcode, undef, 0 ); my $checkout = $item->checkout; - ok( defined($checkout), "Successfully checked out an item prior to renewal"); + ok( defined($checkout), "Successfully checked out an item prior to renewal" ); - my $ils = C4::SIP::ILS->new({ id => $library->branchcode }); + my $ils = C4::SIP::ILS->new( { id => $library->branchcode } ); my $transaction = $ils->renew( $patron->cardnumber, "", $item->barcode );