Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27600: Remove password check from SIP2 renew_all

Browse source 
This patch removes the password check code from the renew_all method for
SIP2. This is required, as many units send an empty AD field in the SIP
message which can cause the transaction to fail.. but the authentication
should have already taken place earlier in the session.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2021-02-03 10:03:31 +00:00 committed by Kyle M Hall
parent 3724e16468
commit 32e27ff22c
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
C4/SIP/ILS.pm
View file

@ -511,15 +511,12 @@ sub renew_all {
siplog("LOG_DEBUG", "ILS::renew_all: Invalid patron id: '%s'", $patron_id); siplog("LOG_DEBUG", "ILS::renew_all: Invalid patron id: '%s'", $patron_id);
} }
if (!defined($patron)) { if (!$patron) {
$trans->screen_msg("Invalid patron barcode."); $trans->screen_msg("Invalid patron barcode.");
return $trans; return $trans;
} elsif (!$patron->renew_ok) { } elsif (!$patron->renew_ok) {
$trans->screen_msg("Renewals not allowed."); $trans->screen_msg("Renewals not allowed.");
return $trans; return $trans;
} elsif (defined($patron_pwd) && !$patron->check_password($patron_pwd)) {
$trans->screen_msg("Invalid patron password.");
return $trans;
} }
$trans->do_renew_all; $trans->do_renew_all;