Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 16229: Deep copy on setting in cache

Browse source 
Koha::Cache->set_in_cache should deep copy (if needed) to avoid the
value which has been set in cache to be unintentionally modified later.

Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2016-04-08 12:43:48 +01:00 committed by Brendan Gallagher
parent 956dc953b5
commit 33ad907a82
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Koha/Cache.pm
View file

@ -281,6 +281,7 @@ sub set_in_cache {
$expiry //= $self->{timeout};
my $set_sub = $self->{ref($self->{$cache}) . "_set"};
$value = clone $value;
# Set in L1 cache
$L1_cache{ $key } = $value;

4
t/Cache.t
View file

@ -17,7 +17,7 @@
use Modern::Perl;
use Test::More tests => 38;
use Test::More tests => 39;
my $destructorcount = 0;
@ -196,6 +196,8 @@ SKIP: {
$item_from_cache = $cache->get_from_cache('test_deep_copy_hash');
%$item_from_cache = ( another => 'hashref' );
is_deeply( $cache->get_from_cache('test_deep_copy_hash'), { a => 'hashref' }, 'A hash will be deep copied');
%item = ( a_modified => 'hashref' );
is_deeply( $cache->get_from_cache('test_deep_copy_hash'), { a => 'hashref' }, 'A hash will be deep copied when set in cache');
$item_from_cache = $cache->get_from_cache('test_deep_copy_hash', { unsafe => 1});
%$item_from_cache = ( another => 'hashref' );
is_deeply( $cache->get_from_cache('test_deep_copy_hash'), { another => 'hashref' }, 'A hash will not be deep copied if the unsafe flag is set');