Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm

Browse source 
- Subroutine prototypes used at line 161, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This commit is contained in:
Mason James 2012-06-27 02:02:26 +12:00 committed by Paul Poulain
parent b744352447
commit 33ae9c9185
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
C4/Serials.pm
View file

@ -160,7 +160,7 @@ After this function, don't forget to execute it by using $sth->execute($subscrip
=cut =cut
sub GetSubscriptionHistoryFromSubscriptionId() { sub GetSubscriptionHistoryFromSubscriptionId {
my $dbh = C4::Context->dbh; my $dbh = C4::Context->dbh;
my $query = qq| my $query = qq|
SELECT * SELECT *
@ -180,7 +180,7 @@ $sth = $dbh->prepare($query).
=cut =cut
sub GetSerialStatusFromSerialId() { sub GetSerialStatusFromSerialId {
my $dbh = C4::Context->dbh; my $dbh = C4::Context->dbh;
my $query = qq| my $query = qq|
SELECT status SELECT status
@ -1179,7 +1179,7 @@ $nextexepected = {
=cut =cut
sub GetNextExpected($) { sub GetNextExpected {
my ($subscriptionid) = @_; my ($subscriptionid) = @_;
my $dbh = C4::Context->dbh; my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare('SELECT serialid, planneddate FROM serial WHERE subscriptionid=? AND status=?'); my $sth = $dbh->prepare('SELECT serialid, planneddate FROM serial WHERE subscriptionid=? AND status=?');
@ -1214,7 +1214,7 @@ returns 0
=cut =cut
sub ModNextExpected($$) { sub ModNextExpected {
my ( $subscriptionid, $date ) = @_; my ( $subscriptionid, $date ) = @_;
my $dbh = C4::Context->dbh; my $dbh = C4::Context->dbh;
@ -2295,7 +2295,7 @@ Return 0 if periodicity==0
=cut =cut
sub GetNextDate(@) { sub GetNextDate {
my ( $planneddate, $subscription ) = @_; my ( $planneddate, $subscription ) = @_;
my @irreg = split( /\,/, $subscription->{irregularity} ); my @irreg = split( /\,/, $subscription->{irregularity} );