Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Starting rewrite of Catalogue.pm using Paul's new marc schema, and Alan's

Browse source 
koha-wide ban on $dbh->quote.  :)
This commit is contained in:
tonnesen 2002-05-16 18:10:35 +00:00
parent 0af09bc098
commit 3437472f27
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
C4/Catalogue.pm
View file

@ -65,28 +65,26 @@ sub newBiblio {
my ($env, $biblio) = @_; my ($env, $biblio) = @_;
my $dbh=&C4Connect; my $dbh=&C4Connect;
my $title=$biblio->{'title'}; my $title=$biblio->{'title'};
my $q_title=$dbh->quote($title);
my $subtitle=$biblio->{'subtitle'}; my $subtitle=$biblio->{'subtitle'};
my $q_subtitle=$dbh->quote($subtitle);
($q_subtitle) || ($q_subtitle="''");
my $author=$biblio->{'author'}; my $author=$biblio->{'author'};
my $q_author=$dbh->quote($author);
my $unititle=$biblio->{'unititle'}; my $unititle=$biblio->{'unititle'};
my $q_unititle=$dbh->quote($unititle);
my $copyrightdate=$biblio->{'copyrightdate'}; my $copyrightdate=$biblio->{'copyrightdate'};
my $serial=$biblio->{'serial'}; my $serial=$biblio->{'serial'};
my $seriestitle=$biblio->{'seriestitle'}; my $seriestitle=$biblio->{'seriestitle'};
my $q_seriestitle=$dbh->quote($seriestitle);
my $notes=$biblio->{'notes'}; my $notes=$biblio->{'notes'};
my $q_notes=$dbh->quote($notes);
my $subject=$biblio->{'subject'}; my $subject=$biblio->{'subject'};
my $additionalauthors=$biblio->{'additionalauthors'}; my $additionalauthors=$biblio->{'additionalauthors'};
# Why am I doing this? This is a potential race condition. At the very least,
# this needs code to ensure that two inserts didn't use the same
# biblionumber...
my $sth=$dbh->prepare("select max(biblionumber) from biblio"); my $sth=$dbh->prepare("select max(biblionumber) from biblio");
$sth->execute; $sth->execute;
my ($biblionumber) = $sth->fetchrow; my ($biblionumber) = $sth->fetchrow;
$biblionumber++; $biblionumber++;
$sth=$dbh->prepare("insert into biblio (biblionumber,title,author,unititle,copyrightdate,serial,seriestitle,notes) values ($biblionumber,$q_title,$q_author,$q_unititle,$copyrightdate,$serial,$q_seriestitle,$q_notes)"); $sth=$dbh->prepare("insert into biblio (biblionumber,title,author,unititle,copyrightdate,serial,seriestitle,notes) values (?, ?, ?, ?, ?, ?, ?, ?)");
$sth->execute; $sth->execute($biblionumber, $title, $author, $unititle, $copyrightdate, $serial, $seriestitle, $notes);
$sth=$dbh->prepare("insert into bibliosubtitle (biblionumber,subtitle) values ($biblionumber,$q_subtitle)"); $sth=$dbh->prepare("insert into bibliosubtitle (biblionumber,subtitle) values ($biblionumber,$q_subtitle)");
$sth->execute; $sth->execute;
foreach (@$subject) { foreach (@$subject) {
@ -95,9 +93,8 @@ sub newBiblio {
$sth->execute; $sth->execute;
} }
foreach (@$additionalauthors) { foreach (@$additionalauthors) {
my $q_additionalauthor=$dbh->quote($_); my $sth=$dbh->prepare("insert into additionalauthors (biblionumber,author) values (?, ?)");
my $sth=$dbh->prepare("insert into additionalauthors (biblionumber,author) values ($biblionumber,$q_additionalauthor)"); $sth->execute($biblionumber, $additionalauthor);
$sth->execute;
} }
} }