Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35248: Add unit tests for Koha::Item->check_booking

Browse source 
This patch adds basic unit tests for the Koha::Item->check_booking
method.

Test plan
1) Run t/db_dependant/Koha/Item.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Martin Renvoize 2024-01-29 18:34:46 +00:00 committed by Katrin Fischer
parent df39d76f30
commit 3496ebee89
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 122 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

123
t/db_dependent/Koha/Item.t
View file

@ -20,7 +20,7 @@
use Modern::Perl;
use utf8;
use Test::More tests => 33;
use Test::More tests => 34;
use Test::Exception;
use Test::MockModule;
@ -2519,3 +2519,124 @@ subtest 'find_booking' => sub {
$schema->storage->txn_rollback;
};
subtest 'check_booking tests' => sub {
plan tests => 5;
$schema->storage->txn_begin;
my $biblio = $builder->build_sample_biblio();
my $item = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, bookable => 1 } );
my $can_book = $item->check_booking(
{
start_date => dt_from_string(),
end_date => dt_from_string()->add( days => 7 )
}
);
is(
$can_book, 1,
"True returned from Koha::Item->check_booking if there are no bookings that would clash"
);
my $start_1 = dt_from_string()->subtract( days => 7 );
my $end_1 = dt_from_string()->subtract( days => 1 );
my $start_2 = dt_from_string();
my $end_2 = dt_from_string()->add( days => 7 );
my $start_3 = dt_from_string()->add( days => 8 );
my $end_3 = dt_from_string()->add( days => 16 );
# Past booking
my $booking1 = $builder->build_object(
{
class => 'Koha::Bookings',
value => {
biblio_id => $biblio->biblionumber,
item_id => $item->itemnumber,
start_date => $start_1,
end_date => $end_1
}
}
);
$can_book = $item->check_booking(
{
start_date => dt_from_string(),
end_date => dt_from_string()->add( days => 7 ),
}
);
is(
$can_book,
1,
"Koha::Item->check_booking returns true when we don't conflict with a past booking"
);
# Current booking
my $booking2 = $builder->build_object(
{
class => 'Koha::Bookings',
value => {
biblio_id => $biblio->biblionumber,
item_id => $item->itemnumber,
start_date => $start_2,
end_date => $end_2
}
}
);
$can_book = $item->check_booking(
{
start_date => dt_from_string(),
end_date => dt_from_string()->add( days => 7 ),
}
);
is(
$can_book,
0,
"Koha::Item->check_booking returns false if the booking would conflict"
);
$can_book = $item->check_booking(
{
start_date => dt_from_string(),
end_date => dt_from_string()->add( days => 7 ),
booking_id => $booking2->booking_id
}
);
is(
$can_book,
1,
"Koha::Item->check_booking returns true if we pass the booking_id that would conflict"
);
$booking2->delete();
# Future booking
my $booking3 = $builder->build_object(
{
class => 'Koha::Bookings',
value => {
biblio_id => $biblio->biblionumber,
item_id => $item->itemnumber,
start_date => $start_3,
end_date => $end_3
}
}
);
$can_book = $item->check_booking(
{
start_date => dt_from_string(),
end_date => dt_from_string()->add( days => 7 ),
}
);
is(
$can_book,
1,
"Koha::Item->check_booking returns true when we don't conflict with a future booking"
);
$schema->storage->txn_rollback;
};