Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35100: (follow-up) Tidy

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Nick Clemens 2024-03-05 12:38:02 +00:00 committed by Martin Renvoize
parent edf978668a
commit 3615baf92f
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
C4/RotatingCollections.pm
View file

@ -487,11 +487,11 @@ sub TransferCollection {
replace => 1 replace => 1
} }
); # Replace transfer ); # Replace transfer
# FIXME: If we just replaced a StockRotationAdvance, # FIXME: If we just replaced a StockRotationAdvance,
# it will get enqueued afresh on the next cron run.. but # it will get enqueued afresh on the next cron run.. but
# that will also push the stage on too.. and what about if # that will also push the stage on too.. and what about if
# we were at the first stage.. then there won't be a datearrived # we were at the first stage.. then there won't be a datearrived
# to calculate against. See bug 35100 # to calculate against. See bug 35100
} }
} }
elsif ( $_->isa('Koha::Exceptions::Item::Transfer::Limit') ) { elsif ( $_->isa('Koha::Exceptions::Item::Transfer::Limit') ) {

2
t/db_dependent/SIP/Transaction.t
View file

@ -405,7 +405,7 @@ subtest do_checkin => sub {
$ci_transaction->do_checkin( $library->branchcode, undef ); $ci_transaction->do_checkin( $library->branchcode, undef );
is( $patron->checkouts->count, 0, 'Checkin should have been done successfully' ); is( $patron->checkouts->count, 0, 'Checkin should have been done successfully' );
my $result = $ci_transaction->do_checkin( $library2->branchcode, undef ); my $result = $ci_transaction->do_checkin( $library2->branchcode, undef );
my $transfer = $item->get_transfer; my $transfer = $item->get_transfer;
is( $ci_transaction->alert_type, '04', "Checkin of item no issued at another branch succeeds" ); is( $ci_transaction->alert_type, '04', "Checkin of item no issued at another branch succeeds" );
is_deeply( is_deeply(