From 3622b51abb082bb009ed6568454ddfff17a3c522 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 13 Jan 2023 12:15:15 +0100 Subject: [PATCH] Bug 32622: Fix Auth.t on D10 It's caused by a version mismatch of Test::MockModule with D10, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449eea9970d70555d44bff We should remove the chaining here. Test plan: Confirm that Auth.t still pass, and is fixed on D10 Signed-off-by: Martin Renvoize (cherry picked from commit d3b4edf009ca7a29341f2dc8a8cebfdc807bad6d) Signed-off-by: Jacob O'Mara (cherry picked from commit b36b7d57519a3d471292e47551ace1aef59d7de6) Signed-off-by: Lucas Gass --- t/db_dependent/Auth.t | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t index 77561b003d..d0112642c5 100755 --- a/t/db_dependent/Auth.t +++ b/t/db_dependent/Auth.t @@ -172,9 +172,11 @@ subtest 'checkauth() tests' => sub { my ( $return ) = C4::Auth::check_cookie_auth( $sessionID, undef, { skip_version_check => 1, remote_addr => '1.2.3.4' } ); is( $return, 'ok', 'Former session in shape now' ); - my $mock1 = Test::MockModule->new('C4::Auth')->mock( 'safe_exit', sub {} ); - my $mock2 = Test::MockModule->new('CGI') ->mock( 'request_method', 'POST' ) - ->mock( 'cookie', sub { return $sessionID; } ); # oversimplified.. + my $mock1 = Test::MockModule->new('C4::Auth'); + $mock1->mock( 'safe_exit', sub {} ); + my $mock2 = Test::MockModule->new('CGI'); + $mock2->mock( 'request_method', 'POST' ); + $mock2->mock( 'cookie', sub { return $sessionID; } ); # oversimplified.. my $cgi = CGI->new; my $password = 'Incr3d1blyZtr@ng93$'; $patron2->set_password({ password => $password });