Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35944: Unit tests

Browse source 
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit e9c541506a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Martin Renvoize 2024-02-20 18:04:49 +00:00 committed by Fridolin Somers
parent 01b22fb71d
commit 371a5cae70
1 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
t/db_dependent/Circulation.t
View file

@ -18,7 +18,7 @@
use Modern::Perl;
use utf8;
use Test::More tests => 69;
use Test::More tests => 70;
use Test::Exception;
use Test::MockModule;
use Test::Deep qw( cmp_deeply );
@ -1733,6 +1733,42 @@ subtest "CanBookBeRenewed tests" => sub {
$recall->set_cancelled;
};
subtest "CanBookBeRenewed | bookings" => sub {
plan tests => 3;
my $schema = Koha::Database->schema;
$schema->storage->txn_begin;
t::lib::Mocks::mock_preference('RenewalPeriodBase', 'date_due');
my $renewing_patron = $builder->build_object( { class => 'Koha::Patrons' } );
my $booked_patron = $builder->build_object( { class => 'Koha::Patrons' } );
my $item = $builder->build_sample_item( { bookable => 1 } );
# issue
my $issue = AddIssue( $renewing_patron, $item->barcode );
my $datedue = dt_from_string( $issue->date_due() );
is( defined $issue->date_due(), 1, "Item checked out, due date: " . $issue->date_due() );
# item-level booking
my $booking = Koha::Booking->new(
{
patron_id => $booked_patron->borrowernumber,
item_id => $item->itemnumber,
biblio_id => $item->biblio->biblionumber,
start_date => $datedue->clone()->add( days => 2 ),
end_date => $datedue->clone()->add( days => 10 ),
}
)->store();
# Proposed renewal would encroach on booking
my ( $renewok, $error ) = CanBookBeRenewed( $renewing_patron, $issue, 0 );
is( $renewok, 0, "Renewal not allowed as it would mean the item was not returned before the next booking" );
is( $error, 'booked', "Error is 'booked'" );
$schema->storage->txn_rollback;
};
subtest "GetUpcomingDueIssues" => sub {
plan tests => 12;