Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34684: Prevent 220600007.pl to fail if run twice

Browse source 
The error is
  ERROR 1292 (22007): Truncated incorrect DECIMAL value: 'no'

Happens on MariaDB 10.5.22, not MySQL 8

Test plan:
update systempreferences set value="0" where variable="DisplayClearScreenButton";
play installer/data/mysql/db_revs/220600007.pl
select value from systempreferences where variable="DisplayClearScreenButton";
=> "no"

update systempreferences set value="1" where variable="DisplayClearScreenButton";
play installer/data/mysql/db_revs/220600007.pl
select value from systempreferences where variable="DisplayClearScreenButton";
=> "issueslip"

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 027e1e1862)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit f73ed6655d)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2023-08-31 17:05:57 +02:00 committed by Matt Blenkinsop
parent aff8ae3160
commit 378af20dd1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
installer/data/mysql/db_revs/220600007.pl
View file

@ -13,7 +13,7 @@ return {
options = 'no|issueslip|issueqslip',
type = 'Choice',
value = CASE value
WHEN 1 THEN 'issueslip'
WHEN "1" THEN 'issueslip'
ELSE 'no'
END
WHERE variable = 'DisplayClearScreenButton';