Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24892: Resolve uninitialized warns from opac-memberentry

Browse source 
Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2020-03-18 13:54:52 +00:00 committed by Martin Renvoize
parent 4c66b9c874
commit 3944f20beb
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
opac/opac-memberentry.pl
View file

@ -497,7 +497,8 @@ sub DelUnchangedFields {
foreach my $key ( keys %new_data ) {
if ( ($current_data->{$key} eq $new_data{$key}) || $hidden_fields->{$key} ) {
next if defined($new_data{$key}) xor defined($current_data->{$key});
if ( !defined($new_data{$key}) || $current_data->{$key} eq $new_data{$key} || $hidden_fields->{$key} ) {
delete $new_data{$key};
}
}