Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32222: Fix capitalization in various "id is invalid"

Browse source 
ID is an abbreviation and should be written with capitals.

See: https://www.oxfordlearnersdictionaries.com/definition/english/identification

This fixes all occurences of "id is invalid" to read "ID is invalid"

To test:
* As some are hard to trigger warnings, the best way here is to review the patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7b3f3ac211)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
This commit is contained in:
Katrin Fischer 2023-02-05 01:51:12 +01:00 committed by Jacob O'Mara
parent d5ef79f226
commit 39612327ce
8 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/Creators/Batch.pm
View file

@ -180,7 +180,7 @@ sub delete {
@query_params = ($opts{'batch_id'}, $opts{'branch_code'});
}
if ($query_params[0] eq '') { # If there is no template id then we cannot delete it
warn sprintf('%s : Cannot delete batch as the batch id is invalid or non-existent.', $call_type);
warn sprintf('%s : Cannot delete batch as the batch ID is invalid or non-existent.', $call_type);
return -1;
}
my $query = "DELETE FROM creator_batches WHERE batch_id = ? AND branch_code =?";

2
C4/Creators/Layout.pm
View file

@ -126,7 +126,7 @@ sub delete {
push @params, $opts{'layout_id'}, $opts{'creator'};
}
if (scalar(@params) < 2) { # If there is no layout id or creator type then we cannot delete it
warn sprintf('%s : Cannot delete layout as the profile id is invalid or non-existent.', $call_type) if !$params[0];
warn sprintf('%s : Cannot delete layout as the profile ID is invalid or non-existent.', $call_type) if !$params[0];
warn sprintf('%s : Cannot delete layout as the creator type is invalid or non-existent.', $call_type) if !$params[1];
return -1;
}

2
C4/Creators/Profile.pm
View file

@ -106,7 +106,7 @@ sub delete {
push @params, $opts{'profile_id'}, $opts{'creator'};
}
if (scalar(@params) < 2) { # If there is no profile id or creator type then we cannot delete it
warn sprintf('%s : Cannot delete profile as the profile id is invalid or non-existent.', $call_type) if !$params[0];
warn sprintf('%s : Cannot delete profile as the profile ID is invalid or non-existent.', $call_type) if !$params[0];
warn sprintf('%s : Cannot delete profile as the creator type is invalid or non-existent.', $call_type) if !$params[1];
return -1;
}

2
C4/Creators/Template.pm
View file

@ -146,7 +146,7 @@ sub delete {
push @query_params, $opts{'template_id'}, $opts{'creator'};
}
if (scalar(@query_params) < 2) { # If there is no template id or creator type then we cannot delete it
warn sprintf('%s : Cannot delete template as the template id is invalid or non-existent.', $call_type) if !$query_params[0];
warn sprintf('%s : Cannot delete template as the template ID is invalid or non-existent.', $call_type) if !$query_params[0];
warn sprintf('%s : Cannot delete template as the creator type is invalid or non-existent.', $call_type) if !$query_params[1];
return -1;
}

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt
View file

@ -70,7 +70,7 @@
<div class="dialog [% m.type | html %]" id="identity_provider_domain_action_result_dialog">
[% SWITCH m.code %]
[% CASE 'error_on_update' %]
<span>An error occurred trying to open the identity provider domain for editing. The passed id is invalid.</span>
<span>An error occurred trying to open the identity provider domain for editing. The passed ID is invalid.</span>
[% CASE 'error_on_insert' %]
<span>An error occurred when adding a new identity provider domain.</span>
[% CASE 'success_on_update' %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
View file

@ -66,7 +66,7 @@
<div class="dialog [% m.type | html %]" id="identity_provider_action_result_dialog">
[% SWITCH m.code %]
[% CASE 'error_on_update' %]
<span>An error occurred trying to open the identity provider for editing. The passed id is invalid.</span>
<span>An error occurred trying to open the identity provider for editing. The passed ID is invalid.</span>
[% CASE 'error_on_insert' %]
<span>An error occurred when adding a new identity provider.</span>
[% CASE 'success_on_update' %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
View file

@ -166,7 +166,7 @@
<h1>Patron restrictions</h1>
[% IF searchfield %]
You Searched for [% searchfield | html %]</span>
You searched for [% searchfield | html %]</span>
[% END %]
[% IF restrictions %]
<div class="page-section">

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
View file

@ -64,7 +64,7 @@
<div class="dialog [% m.type | html %]" id="smtp_action_result_dialog">
[% SWITCH m.code %]
[% CASE 'error_on_update' %]
<span>An error occurred trying to open the server for editing. The passed id is invalid.</span>
<span>An error occurred trying to open the server for editing. The passed ID is invalid.</span>
[% CASE 'error_on_insert' %]
<span>An error occurred when adding the server. The library already has an SMTP server set.</span>
[% CASE 'success_on_update' %]