Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed

Browse source 
The additional materials check when CircConfirmParts is enabled was
errantly relying upon the 'FORCE_CHECKOUT' permission.  This patch
updates the template to allow confirmation as well as cancellation of
chekout.

Test plan
1. Set a staff member with circ permissions, but not FORCE_CHECKOUT
2. Turn on CircConfirmItemParts
3. Log in as staff member in step 1
4. Attempt to checkout an item with a 952$3
5. The only option given is the Continue button (with a red X) and when
   clicked, the item does not get checked out.
6. Apply patch
7. Repeat step 4.
8. You should now have the option to 'Yes, check out (Y)' or
   'No, don't check out (N)'

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 49ef741405)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2021-11-22 11:33:25 +00:00 committed by Lucas Gass
parent 12b90bb02f
commit 39f89b43fd
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
View file

@ -246,7 +246,7 @@
</ul>
[% IF CAN_user_circulate_force_checkout or HIGHHOLDS %]
[% IF CAN_user_circulate_force_checkout or HIGHHOLDS or ADDITIONAL_MATERIALS %]
<form method="post" action="/cgi-bin/koha/circ/circulation.pl" autocomplete="off">
<input type="hidden" name="restoreduedatespec" />
@ -360,7 +360,7 @@
<input type="hidden" name="duedatespec" value="[% duedatespec | html %]" />
<input type="hidden" name="restoreduedatespec" />
<input type="hidden" name="stickyduedate" value="[% stickyduedate | html %]" />
[% IF CAN_user_circulate_force_checkout or HIGHHOLDS %]
[% IF CAN_user_circulate_force_checkout or HIGHHOLDS or ADDITIONAL_MATERIALS %]
[% IF ( RENEW_ISSUE ) %]
<button type="submit" class="deny" accesskey="n"><i class="fa fa-times"></i> No, don't renew (N)</button>
[% ELSE %]