Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 8367: (follow-up) Remove unnecessary code and atomic update

Browse source 
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Aleisha Amohia 2022-11-02 08:48:19 +13:00 committed by Tomas Cohen Arazi
parent c713fa335a
commit 3a1c40a290
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 0 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
installer/data/mysql/atomicupdate/bug_8367-add_holds_pickup_period_circrule.perl
View file

@ -1,10 +0,0 @@
$DBversion = 'XXX';
if( CheckVersion( $DBversion ) ) {
$dbh->do(q{
INSERT INTO circulation_rules (branchcode, categorycode, itemtype, rule_name, rule_value)
SELECT u.* FROM (SELECT NULL as branchcode, NULL as categorycode, NULL as itemtype, 'holds_pickup_period' as rule_name, '' as rule_value) u
WHERE NOT EXISTS ( SELECT rule_name FROM circulation_rules where rule_name = 'holds_pickup_period' );
});
NewVersion( $DBversion, 8367, "Add holds_pickup_period circulation rule" );
}

11
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl vendored
View file

@ -339,17 +339,6 @@ sub GetWaitingHolds {
my $waiting_date = dt_from_string( $issue->{waitingdate}, 'sql' );
my $rule = Koha::CirculationRules->get_effective_rule({
categorycode => $issue->{categorycode},
itemtype => $item->effective_itemtype,
branchcode => $issue->{branchcode},
rule_name => 'holds_pickup_period',
});
if ( defined($rule) and $rule->rule_value ne '' ){
# circulation rule overrides ReservesMaxPickUpDelay
$pickupdelay = $rule->rule_value;
}
$issue->{'date_due'} = output_pref({dt => dt_from_string($issue->{expirationdate}), dateformat => 'iso' });
$issue->{'level'} = 1; # only one level for Hold Waiting notifications