Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30781: Add unit test for substitute with undefined value

Browse source 
Add unit test that generates warn.
This may be usefull as no regression test.

Run prove t/db_dependent/Letters.t
You see warn :
t/db_dependent/Letters.t .. 1/84 Use of uninitialized value $val in substitution iterator at /kohadevbox/koha/C4/Letters.pm line 607.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2e0243c378)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Fridolin Somers 2022-05-18 17:47:18 -10:00 committed by Lucas Gass
parent 6a49c8a1b0
commit 3b3b7f0ad9
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
t/db_dependent/Letters.t
View file

@ -18,7 +18,7 @@
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 83;
use Test::More tests => 85;
use Test::MockModule;
use Test::Warn;
use Test::Exception;
@ -279,6 +279,20 @@ $prepared_letter = GetPreparedLetter((
$my_content_letter = qq|This is a SMS for an $substitute->{status}|;
is( $prepared_letter->{content}, $my_content_letter, 'GetPreparedLetter returns the content correctly' );
warning_is {
$prepared_letter = GetPreparedLetter((
module => 'my module',
branchcode => $library->{branchcode},
letter_code => 'my code',
tables => $tables,
substitute => { status => undef },
repeat => $repeat,
message_transport_type => 'sms',
));
}
undef, "No warning if GetPreparedLetter called with substitute containing undefined value";
is( $prepared_letter->{content}, q|This is a SMS for an |, 'GetPreparedLetter returns the content correctly when substitute contains undefined value' );
$dbh->do(q{INSERT INTO letter (module, code, name, title, content) VALUES ('test_date','TEST_DATE','Test dates','A title with a timestamp: <<biblio.timestamp>>','This one only contains the date: <<biblio.timestamp | dateonly>>.');});
$prepared_letter = GetPreparedLetter((
module => 'test_date',