Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28186: Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority

Browse source 
This patch replaces the use of $dbh->do by corresponding use of
Koha::Authority object

Test plan:
1. Verify that creating/modifying authority still work
2. prove t/db_dependent/AuthoritiesMarc.t

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Julian Maurice 2021-04-21 07:56:50 +02:00 committed by Tomas Cohen Arazi
parent 6123c2767d
commit 3b4c6db0d8
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
C4/AuthoritiesMarc.pm
View file

@ -643,20 +643,24 @@ sub AddAuthority {
# Save record into auth_header, update 001
my $action;
my $authority;
if (!$authid ) {
$action = 'create';
# Save a blank record, get authid
$dbh->do( "INSERT INTO auth_header (datecreated,marcxml) values (NOW(),?)", undef, '' );
$authid = $dbh->last_insert_id( undef, undef, 'auth_header', 'authid' );
$authority = Koha::Authority->new({ datecreated => \'NOW()', marcxml => '' })->store();
$authority->discard_changes();
$authid = $authority->authid;
logaction( "AUTHORITIES", "ADD", $authid, "authority" ) if C4::Context->preference("AuthoritiesLog");
} else {
$action = 'modify';
$authority = Koha::Authorities->find($authid);
}
# Insert/update the recordID in MARC record
$record->delete_field( $record->field('001') );
$record->insert_fields_ordered( MARC::Field->new( '001', $authid ) );
# Update
$dbh->do( "UPDATE auth_header SET authtypecode=?, marc=?, marcxml=? WHERE authid=?", undef, $authtypecode, $record->as_usmarc, $record->as_xml_record($format), $authid ) or die $DBI::errstr;
$authority->update({ authtypecode => $authtypecode, marc => $record->as_usmarc, marcxml => $record->as_xml_record($format) });
unless ( $skip_record_index ) {
my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::AUTHORITIES_INDEX });