Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35001: Add some checks to membership_expiry

Browse source 
Test plan:
Toggle pref TrackLastPatronActivityTriggers (clear it).
And try variations of --active, --inactive to see the warnings.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2023-10-13 08:26:46 +00:00 committed by Tomas Cohen Arazi
parent 5c2c6252fa
commit 3c319d988c
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 31 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
misc/cronjobs/membership_expiry.pl
View file

@ -95,11 +95,19 @@ Optional parameter to use another renewal notice than the default: MEMBERSHIP_RE
=item B<-active> =item B<-active>
Optional parameter to include active patrons only (active within passed number of months). Optional parameter to include active patrons only (active within passed number of months).
This parameter needs the preference TrackLastPatronActivityTriggers.
IMPORTANT: You should be using those triggers already for the period that you
consider a user to be (in)active.
=item B<-inactive> =item B<-inactive>
Optional parameter to include inactive patrons only (inactive within passed number of months). Optional parameter to include inactive patrons only (inactive within passed number of months).
This allows you to e.g. send expiry warnings only to inactive patrons. This allows you to e.g. send expiry warnings only to inactive patrons.
This parameter needs the preference TrackLastPatronActivityTriggers.
IMPORTANT: You should be using those triggers already for the period that you
consider a user to be (in)active.
=item B<-renew> =item B<-renew>
@ -194,11 +202,29 @@ $letter_renew = 'MEMBERSHIP_RENEWED' if !$letter_renew;
pod2usage( -verbose => 2 ) if $man; pod2usage( -verbose => 2 ) if $man;
pod2usage(1) if $help || !$confirm; pod2usage(1) if $help || !$confirm;
pod2usage( # Check active/inactive. Note that passing no value or zero is a no-op.
-verbose => 1, if ( !C4::Context->preference('TrackLastPatronActivityTriggers')
-msg => q{The --active and --inactive flags are mutually exclusive}, && ( $active || $inactive ) )
-exitval => 1 {
) if defined $active && defined $inactive; pod2usage(
-verbose => 1,
-msg =>
q{Exiting membership_expiry.pl: Using --active or --inactive needs use of TrackLastPatronActivityTriggers over specified period},
-exitval => 1
);
} elsif ( $active && $inactive ) {
pod2usage(
-verbose => 1,
-msg => q{The --active and --inactive flags are mutually exclusive},
-exitval => 1
);
} elsif ( ( defined $active && !$active ) || ( defined $inactive && !$inactive ) ) {
pod2usage(
-verbose => 1,
-msg => q{Options --active and --inactive need a number of months},
-exitval => 1
);
}
cronlogaction({ info => $command_line_options }); cronlogaction({ info => $command_line_options });