Browse Source

Bug 19935: Replace GetPendingIssues - Discharges

We should actually use Koha::Patron->checkouts here to avoid the
prefetch.

Test plan:
A patron with checkouts cannot get a discharge

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
18.05.x
Jonathan Druart 6 years ago
parent
commit
3c4677efc7
  1. 13
      Koha/Patron/Discharge.pm

13
Koha/Patron/Discharge.pm

@ -6,7 +6,6 @@ use File::Temp qw( :POSIX );
use Carp;
use C4::Templates qw ( gettemplate );
use C4::Members qw( GetPendingIssues );
use Koha::Database;
use Koha::DateUtils qw( dt_from_string output_pref );
@ -34,13 +33,11 @@ sub can_be_discharged {
my ($params) = @_;
return unless $params->{borrowernumber};
my $issues = GetPendingIssues( $params->{borrowernumber} );
if( @$issues ) {
return 0;
}
else {
return 1;
}
my $patron = Koha::Patrons->find( $params->{borrowernumber} );
return unless $patron;
my $has_pending_checkouts = $patron->pending_checkouts->count;
return $has_pending_checkouts ? 0 : 1;
}
sub is_discharged {

Loading…
Cancel
Save