Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

Browse source 
This patch makes changes to the libraries administration page so that
the page title, breadcrumbs, and page headings are more consistent with
each other.

To test, apply the patch and go to Administration -> Libraries.

- Click "New library"
- The page title, breadcrumb navigation, and page heading should all
  read "New library"
- Enter some details, save your new library, and then click the "Delete"
  button corresponding to your new library.
- On the deletion conformation page, the page title and breadcrumb
  navigation should match, "Confirm deletion of library 'X'"
- Edit a library. On the edit page, the page title, breadcrumb
  navigation, and page heading should match: "Modify library 'X'"

Signed-off-by: paul <paul.poulain@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-08-18 08:39:50 +00:00 committed by Tomas Cohen Arazi
parent c7daaa901b
commit 3c5b129f1d
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
View file

@ -11,9 +11,9 @@
<title>[% FILTER collapse %]
[% IF op == 'add_form' %]
[% IF library %]
[% t("Modify library") | html %]
[% tx("Modify library '{library}'", { library = library.branchcode }) | html %]
[% ELSE %]
[% tx("New library {library}", { library = library.branchcode }) | html %]
[% t("New library") | html %]
[% END %] &rsaquo;
[% ELSIF op == 'delete_confirm' %]
[% tx("Confirm deletion of library '{library}'", { library = library.branchcode }) | html %] &rsaquo;
@ -49,17 +49,17 @@
[% IF op == 'add_form' %]
[% IF library %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Modify library</span>
[% tx("Modify library '{library}'", { library = library.branchcode }) | html %]
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>New library [% library.branchcode | html %]</span>
<span>New library</span>
[% END %]
[% END %]
[% ELSIF op == 'delete_confirm' %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Confirm deletion of library '[% library.branchcode | html %]'</span>
[% tx("Confirm deletion of library '{library}'", { library = library.branchcode }) | html %]
[% END %]
[% ELSIF op == 'view' %]
@ -116,7 +116,13 @@
[% END %]
[% IF op == 'add_form' %]
<h1>[% IF library %]Modify library[% ELSE %]New library[% END %]</h1>
<h1>
[% IF library %]
[% tx("Modify library '{library}'", { library = library.branchcode }) | html %]
[% ELSE %]
New library
[% END %]
</h1>
<form action="/cgi-bin/koha/admin/branches.pl" id="Aform" name="Aform" class="validated" method="post">
<fieldset class="rows">
<input type="hidden" name="op" value="add_validate" />