Bug 25238: Fix semantic heading for opac-details

Prior to this patch the opac-details view contained multiple h1 level
headings.

Test plan
1/ Perform a search in the OPAC that will yield results
2/ Navigate to any results detailed view
3/ Inspect the page and note that two H1 level headings are present
(Page title + Item title)
4/ Apply the patch
5/ Reload the page
6/ Inspect the page and ntoe that the 'Item title' is now a level 2
heading
7/ Note the page still appears nicely
8/ Signoff

Bonus points: Check with XSLT views enabled and disabled, MARC21,
UNIMARC and NORMARC variations.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2020-06-11 12:15:21 +01:00 committed by Jonathan Druart
parent 1a96ede5f1
commit 3e18402c24
4 changed files with 9 additions and 9 deletions

View file

@ -130,7 +130,7 @@
[% IF ( OPACXSLTDetailsDisplay ) %] [% IF ( OPACXSLTDetailsDisplay ) %]
[% XSLTBloc | $raw %] [% XSLTBloc | $raw %]
[% ELSE %] [% ELSE %]
<h1 class="title">[% INCLUDE 'biblio-title.inc' %]</h1> <h2 class="title">[% INCLUDE 'biblio-title.inc' %]</h2>
[% IF ( author ) %]<h5 class="author">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></h5>[% END %] [% IF ( author ) %]<h5 class="author">by <a class="contributors" href="/cgi-bin/koha/opac-search.pl?q=au:[% author |url %]">[% author | html %]</a></h5>[% END %]
<span class="results_summary">[% UNLESS ( item_level_itypes ) %] <span class="results_summary">[% UNLESS ( item_level_itypes ) %]

View file

@ -119,17 +119,17 @@
<!-- Title Statement --> <!-- Title Statement -->
<!-- Alternate Graphic Representation (MARC 880) --> <!-- Alternate Graphic Representation (MARC 880) -->
<xsl:if test="$display880"> <xsl:if test="$display880">
<h1 class="title" property="alternateName"> <h2 class="title" property="alternateName">
<xsl:call-template name="m880Select"> <xsl:call-template name="m880Select">
<xsl:with-param name="basetags">245</xsl:with-param> <xsl:with-param name="basetags">245</xsl:with-param>
<xsl:with-param name="codes">abhfgknps</xsl:with-param> <xsl:with-param name="codes">abhfgknps</xsl:with-param>
</xsl:call-template> </xsl:call-template>
</h1> </h2>
</xsl:if> </xsl:if>
<!--Bug 13381 --> <!--Bug 13381 -->
<xsl:if test="marc:datafield[@tag=245]"> <xsl:if test="marc:datafield[@tag=245]">
<h1 class="title" property="name"> <h2 class="title" property="name">
<xsl:for-each select="marc:datafield[@tag=245]"> <xsl:for-each select="marc:datafield[@tag=245]">
<xsl:call-template name="subfieldSelect"> <xsl:call-template name="subfieldSelect">
<xsl:with-param name="codes">a</xsl:with-param> <xsl:with-param name="codes">a</xsl:with-param>
@ -154,7 +154,7 @@
</xsl:choose> </xsl:choose>
</xsl:for-each> </xsl:for-each>
</xsl:for-each> </xsl:for-each>
</h1> </h2>
</xsl:if> </xsl:if>

View file

@ -67,7 +67,7 @@
<!-- Tittel og ansvarsopplysninger --> <!-- Tittel og ansvarsopplysninger -->
<xsl:if test="marc:datafield[@tag=245]"> <xsl:if test="marc:datafield[@tag=245]">
<h1 class="title"> <h2 class="title">
<xsl:for-each select="marc:datafield[@tag=245]"> <xsl:for-each select="marc:datafield[@tag=245]">
<xsl:call-template name="subfieldSelect"> <xsl:call-template name="subfieldSelect">
<xsl:with-param name="codes">a</xsl:with-param> <xsl:with-param name="codes">a</xsl:with-param>
@ -89,7 +89,7 @@
<xsl:with-param name="codes">np</xsl:with-param> <xsl:with-param name="codes">np</xsl:with-param>
</xsl:call-template> </xsl:call-template>
</xsl:for-each> </xsl:for-each>
</h1> </h2>
</xsl:if> </xsl:if>
<!-- Author Statement --> <!-- Author Statement -->

View file

@ -25,7 +25,7 @@
<xsl:if test="marc:datafield[@tag=200]"> <xsl:if test="marc:datafield[@tag=200]">
<xsl:for-each select="marc:datafield[@tag=200]"> <xsl:for-each select="marc:datafield[@tag=200]">
<h1 class="title"> <h2 class="title">
<xsl:call-template name="addClassRtl" /> <xsl:call-template name="addClassRtl" />
<xsl:for-each select="marc:subfield"> <xsl:for-each select="marc:subfield">
<xsl:choose> <xsl:choose>
@ -62,7 +62,7 @@
</xsl:otherwise> </xsl:otherwise>
</xsl:choose> </xsl:choose>
</xsl:for-each> </xsl:for-each>
</h1> </h2>
</xsl:for-each> </xsl:for-each>
</xsl:if> </xsl:if>