Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 22477: Missing DataTables configuration when searching patrons for holds

Browse source 
This patch adds columns configuration to the holds request page to fix a
JavaScript error in the console and to allow the patron search results
table to be enabled as a DataTable.

To reproduce: Place a hold on a title in the staff client. When prompted
for a patron, perform a search which will return multiple results. The
patron search results will appear in an unsortable table. A JS error can
be seen in the browser console.

To test, apply the patch and repeat the steps above. The patron search
results table should be sortable and there should be no JS error.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2019-03-07 17:28:34 +00:00 committed by Nick Clemens
parent 3d462af21f
commit 3e7620cf46
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View file

@ -658,6 +658,7 @@
[% MACRO jsinclude BLOCK %] [% MACRO jsinclude BLOCK %]
[% INCLUDE 'datatables.inc' %] [% INCLUDE 'datatables.inc' %]
[% INCLUDE 'calendar.inc' %] [% INCLUDE 'calendar.inc' %]
[% INCLUDE 'columns_settings.inc' %]
[% Asset.js("js/circ-patron-search-results.js") | $raw %] [% Asset.js("js/circ-patron-search-results.js") | $raw %]
<script> <script>
var MSG_CONFIRM_DELETE_HOLD = _("Are you sure you want to cancel this hold?"); var MSG_CONFIRM_DELETE_HOLD = _("Are you sure you want to cancel this hold?");
@ -670,6 +671,7 @@
[% END %][% END %][% END %] [% END %][% END %][% END %]
}; };
var MSG_NO_ITEMS_AVAILABLE = _("A hold cannot be requested on any of these items."); var MSG_NO_ITEMS_AVAILABLE = _("A hold cannot be requested on any of these items.");
columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %]
$(document).ready(function() { $(document).ready(function() {
function ToggleHoldsToPlace() { function ToggleHoldsToPlace() {