Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27333: Regression tests

Browse source 
Test for the right exceptions

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomás Cohen Arazi 2021-01-04 11:09:54 -03:00 committed by Jonathan Druart
parent 17a3476d7e
commit 3ece596486
1 changed files with 71 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

91
t/db_dependent/Koha/Club/Hold.t
View file

@ -36,7 +36,8 @@ my $builder = t::lib::TestBuilder->new;
my $schema = Koha::Database->new->schema;
subtest 'add' => sub {
plan tests => 5;
plan tests => 9;
$schema->storage->txn_begin;
@ -45,32 +46,82 @@ subtest 'add' => sub {
my $item1 = $builder->build_sample_item({ library => $library->branchcode });
my $item2 = $builder->build_sample_item({ library => $library->branchcode });
try {
Koha::Club::Hold::add({ club_id => $club->id, biblio_id => $item1->biblionumber, pickup_library_id => $library->branchcode });
} catch {
my $class = ref $_;
ok($class eq 'Koha::Exceptions::ClubHold::NoPatrons', 'Exception thrown when no patron is enrolled in club');
};
throws_ok {
Koha::Club::Hold::add(
{
club_id => $club->id
}
);
}
'Koha::Exceptions::MissingParameter',
'Exception thrown when biblio_id is passed';
my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $library->branchcode } });
my $e = $builder->build_object({ class => 'Koha::Club::Enrollments' , value => { club_id => $club->id, borrowernumber => $patron->borrowernumber, date_canceled => undef }} );
is( "$@", 'The biblio_id parameter is mandatory' );
my $club_hold = Koha::Club::Hold::add({
club_id => $club->id,
biblio_id => $item1->biblionumber,
pickup_library_id => $library->branchcode
});
throws_ok {
Koha::Club::Hold::add(
{
biblio_id => $item1->biblionumber
}
);
}
'Koha::Exceptions::MissingParameter',
'Exception thrown when club_id is passed';
is( "$@", 'The club_id parameter is mandatory' );
throws_ok {
Koha::Club::Hold::add(
{
club_id => $club->id,
biblio_id => $item1->biblionumber,
pickup_library_id => $library->branchcode
}
);
}
'Koha::Exceptions::ClubHold::NoPatrons',
'Exception thrown when no patron is enrolled in club';
my $patron = $builder->build_object(
{
class => 'Koha::Patrons',
value => { branchcode => $library->branchcode }
}
);
my $e = $builder->build_object(
{
class => 'Koha::Club::Enrollments',
value => {
club_id => $club->id,
borrowernumber => $patron->borrowernumber,
date_canceled => undef
}
}
);
my $club_hold = Koha::Club::Hold::add(
{
club_id => $club->id,
biblio_id => $item1->biblionumber,
pickup_library_id => $library->branchcode
}
);
is(blessed($club_hold), 'Koha::Club::Hold', 'add returns a Koha::Club::Hold');
$e->date_canceled(dt_from_string)->store;
try {
Koha::Club::Hold::add({ club_id => $club->id, biblio_id => $item2->biblionumber, pickup_library_id => $library->branchcode });
} catch {
my $class = ref $_;
ok($class eq 'Koha::Exceptions::ClubHold::NoPatrons', 'Exception thrown when no patron is enrolled in club');
};
throws_ok {
Koha::Club::Hold::add(
{
club_id => $club->id,
biblio_id => $item2->biblionumber,
pickup_library_id => $library->branchcode
}
);
}
'Koha::Exceptions::ClubHold::NoPatrons',
'Exception thrown when no patron is enrolled in club';
my $patron_holds = Koha::Club::Hold::PatronHolds->search({ club_hold_id => $club_hold->id });