From 3f6a7933b84ba95550518b0364a9ba90002390b5 Mon Sep 17 00:00:00 2001 From: Jenny Way Date: Wed, 17 Jan 2018 21:48:57 +0000 Subject: [PATCH] Bug 19992: use Modern::Perl in Admin perl scripts Test plan: Check use warnings; use strict doesn't exist and use Modern::Perl is written instead in the following files: admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- admin/admin-home.pl | 3 +-- admin/aqcontract.pl | 3 +-- admin/aqplan.pl | 3 +-- admin/auth_tag_structure.pl | 3 +-- admin/branch_transfer_limits.pl | 3 +-- admin/check_budget_parent.pl | 3 +-- admin/check_parent_total.pl | 3 +-- admin/checkmarc.pl | 3 +-- admin/classsources.pl | 3 +-- admin/clone-rules.pl | 3 +-- admin/didyoumean.pl | 3 +-- admin/edi_accounts.pl | 3 +-- admin/edi_ean_accounts.pl | 3 +-- admin/import_export_framework.pl | 3 +-- admin/item_circulation_alerts.pl | 3 +-- admin/marctagstructure.pl | 3 +-- admin/matching-rules.pl | 3 +-- admin/printers.pl | 3 +-- admin/smart-rules.pl | 3 +-- admin/systempreferences.pl | 3 +-- admin/transport-cost-matrix.pl | 3 +-- 21 files changed, 21 insertions(+), 42 deletions(-) diff --git a/admin/admin-home.pl b/admin/admin-home.pl index 08c6ed196a..7c1d0581be 100755 --- a/admin/admin-home.pl +++ b/admin/admin-home.pl @@ -15,8 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/admin/aqcontract.pl b/admin/aqcontract.pl index e35b057073..e4f1d8d139 100755 --- a/admin/aqcontract.pl +++ b/admin/aqcontract.pl @@ -20,8 +20,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Auth; diff --git a/admin/aqplan.pl b/admin/aqplan.pl index f96086e013..ebad0426b5 100755 --- a/admin/aqplan.pl +++ b/admin/aqplan.pl @@ -20,8 +20,7 @@ #written 20/02/2002 by paul.poulain@free.fr # This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html) -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use List::Util qw/min/; use Date::Calc qw/Delta_YMD Easter_Sunday Today Decode_Date_EU/; diff --git a/admin/auth_tag_structure.pl b/admin/auth_tag_structure.pl index c2b07621e6..121e04f17d 100755 --- a/admin/auth_tag_structure.pl +++ b/admin/auth_tag_structure.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; use C4::Koha; diff --git a/admin/branch_transfer_limits.pl b/admin/branch_transfer_limits.pl index 84d7210961..681f85b6bd 100755 --- a/admin/branch_transfer_limits.pl +++ b/admin/branch_transfer_limits.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/admin/check_budget_parent.pl b/admin/check_budget_parent.pl index ab9941351e..0fdedfbfc9 100755 --- a/admin/check_budget_parent.pl +++ b/admin/check_budget_parent.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Output; diff --git a/admin/check_parent_total.pl b/admin/check_parent_total.pl index 10f1036639..6da8d28668 100755 --- a/admin/check_parent_total.pl +++ b/admin/check_parent_total.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Output; diff --git a/admin/checkmarc.pl b/admin/checkmarc.pl index 456f22bea9..ec4b954236 100755 --- a/admin/checkmarc.pl +++ b/admin/checkmarc.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use C4::Output; use C4::Auth; use CGI qw ( -utf8 ); diff --git a/admin/classsources.pl b/admin/classsources.pl index 539095f457..ff6d86e36e 100755 --- a/admin/classsources.pl +++ b/admin/classsources.pl @@ -18,8 +18,7 @@ # along with Koha; if not, see . # -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; use C4::Context; diff --git a/admin/clone-rules.pl b/admin/clone-rules.pl index 9fd330fa71..73d0f54878 100755 --- a/admin/clone-rules.pl +++ b/admin/clone-rules.pl @@ -25,8 +25,7 @@ # # The script can be called with one of the parameters, both or none -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Output; diff --git a/admin/didyoumean.pl b/admin/didyoumean.pl index 52ebeaa487..d34ed044f3 100755 --- a/admin/didyoumean.pl +++ b/admin/didyoumean.pl @@ -1,7 +1,6 @@ #!/usr/bin/perl -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Auth; diff --git a/admin/edi_accounts.pl b/admin/edi_accounts.pl index 9225b7ced8..e6f8676ee6 100755 --- a/admin/edi_accounts.pl +++ b/admin/edi_accounts.pl @@ -17,8 +17,7 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use strict; -use warnings; +use Modern::Perl; use CGI; use C4::Auth; use C4::Output; diff --git a/admin/edi_ean_accounts.pl b/admin/edi_ean_accounts.pl index d6e8d953c2..e22b04aead 100755 --- a/admin/edi_ean_accounts.pl +++ b/admin/edi_ean_accounts.pl @@ -17,8 +17,7 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use strict; -use warnings; +use Modern::Perl; use CGI; use C4::Auth; use C4::Output; diff --git a/admin/import_export_framework.pl b/admin/import_export_framework.pl index de1f195894..237be1d80a 100755 --- a/admin/import_export_framework.pl +++ b/admin/import_export_framework.pl @@ -18,8 +18,7 @@ # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use CGI::Cookie; use C4::Context; diff --git a/admin/item_circulation_alerts.pl b/admin/item_circulation_alerts.pl index 5e9c463e3f..ea8b4e90ee 100755 --- a/admin/item_circulation_alerts.pl +++ b/admin/item_circulation_alerts.pl @@ -15,8 +15,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use File::Basename; diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl index e7d6b74398..3ca143b000 100755 --- a/admin/marctagstructure.pl +++ b/admin/marctagstructure.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; use C4::Koha; diff --git a/admin/matching-rules.pl b/admin/matching-rules.pl index 20d9f82942..3c30e94288 100755 --- a/admin/matching-rules.pl +++ b/admin/matching-rules.pl @@ -18,8 +18,7 @@ # along with Koha; if not, see . # -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/admin/printers.pl b/admin/printers.pl index cb43148804..bd30bde139 100755 --- a/admin/printers.pl +++ b/admin/printers.pl @@ -37,8 +37,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Output; diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl index 6a55b7bde4..e9a7ad64cf 100755 --- a/admin/smart-rules.pl +++ b/admin/smart-rules.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Output; diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl index 6abf38b76a..b16143f723 100755 --- a/admin/systempreferences.pl +++ b/admin/systempreferences.pl @@ -40,8 +40,7 @@ ALSO : =cut -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use MIME::Base64; diff --git a/admin/transport-cost-matrix.pl b/admin/transport-cost-matrix.pl index 0aab030729..ea1086df42 100755 --- a/admin/transport-cost-matrix.pl +++ b/admin/transport-cost-matrix.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Context; use C4::Output;