Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33919: Improve translation of title tags: Patron clubs

Browse source 
This patch updates patron clubs templates so that title tags can be more
easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron clubs
  - New and Edit club template
  - New and Edit club
  - Club enrollments (from the list of clubs choose Actions ->
    Enrollments)

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-06-06 15:14:31 +00:00 committed by Tomas Cohen Arazi
parent 8ff6189c2a
commit 3f6b956533
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
4 changed files with 36 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
View file

@ -3,11 +3,16 @@
[% USE KohaDates %]
[% USE Branches %]
[% USE Koha %]
[% USE AuthorisedValues %]
[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %]
[% USE HtmlTags %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Club enrollments &rsaquo; Patron clubs &rsaquo; Tools &rsaquo; Koha</title>
<title>[% FILTER collapse %]
[% tx("Club enrollments for {club_name}", { club_name = club.name }) | html %] &rsaquo;
[% t("Patron clubs") | html %] &rsaquo;
[% t("Tools") | html %] &rsaquo;
[% t("Koha") | html %]
[% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
@ -25,7 +30,7 @@
<a href="clubs.pl">Patron clubs</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Club enrollments</span>
<span>Club enrollments for [% club.name | html | $HtmlTags tag="em" %]</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
@ -37,7 +42,7 @@
[% IF !club %]
<div class="dialog message">The club you requested does not exist.</div>
[% ELSE %]
<h1>Club enrollments for <em>[% club.name | html %]</em></h1>
<h1>Club enrollments for [% club.name | html | $HtmlTags tag="em" %]</h1>
<div class="page-section">
<table id="enrollments-table">

14
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt
View file

@ -3,15 +3,19 @@
[% USE KohaDates %]
[% USE Branches %]
[% USE AuthorisedValues %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>
<title>[% FILTER collapse %]
[% IF club %]
Modify club [% club.name | html %]
[% tx("Modify club {club_name}", { club_name = club.name }) | html %]
[% ELSE %]
Create a new [% club_template.name | html %] club
[% END %] &rsaquo; Patron clubs &rsaquo; Tools &rsaquo; Koha
</title>
[% tx("Create a new {club_template} club", { club_template = club_template.name }) | html %]
[% END %] &rsaquo;
[% t("Patron clubs") | html %] &rsaquo;
[% t("Tools") | html %] &rsaquo;
[% t("Koha") | html %]
[% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>

7
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
View file

@ -3,9 +3,14 @@
[% USE KohaDates %]
[% USE Branches %]
[% USE Koha %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Patron clubs &rsaquo; Tools &rsaquo; Koha</title>
<title>[% FILTER collapse %]
[% t("Patron clubs") | html %] &rsaquo;
[% t("Tools") | html %] &rsaquo;
[% t("Koha") | html %]
[% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>

18
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt
View file

@ -2,15 +2,19 @@
[% USE Branches %]
[% USE AuthorisedValues %]
[% USE HtmlTags %]
[% PROCESS 'i18n.inc' %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>
<title>[% FILTER collapse %]
[% IF club_template %]
Modify club template [% club_template.name | html %]
[% tx("Modify club template {club_template}", { club_template = club_template.name }) | html %] &rsaquo;
[% ELSE %]
Create a new club template
[% END %] &rsaquo; Patron clubs &rsaquo; Tools &rsaquo; Koha
</title>
[% t("New club template") | html %]
[% END %] &rsaquo;
[% t("Patron clubs") | html %] &rsaquo;
[% t("Tools") | html %] &rsaquo;
[% t("Koha") | html %]
[% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
<style>
.club-field,
@ -37,7 +41,7 @@
[% IF club_template %]
<span>Modify club template [% club_template.name | html | $HtmlTags tag="em" %]</span>
[% ELSE %]
<span>Create a new club template</span>
<span>New club template</span>
[% END %]
[% END %]
[% END #/ WRAPPER breadcrumbs %]
@ -54,7 +58,7 @@
[% IF club_template %]
<span>Modify club template [% club_template.name | html | $HtmlTags tag="em" %]</span>
[% ELSE %]
<span>Create a new club template</span>
<span>New club template</span>
[% END %]
</h1>