Browse Source

Bug 30689: Incorrect Babeltheque setting can cause console warning

This patch adds an additional system preference check to the part of the
OPAC bibliographic detail template which conditionally loads Babelthèque
JavaScript. The script tag should not be output if there is no
Babeltheque_url_js setting to use.

To test, apply the patch and search for "Babeltheque" in system
preferences.

 - Set "Babeltheque" to "Do" include information.
 - Enter a path in the "Babeltheque_url_js" preference, e.g.
   "https://www.example.com/example.js" It doesn't have to be a valid
   Babeltheque URL.
 - In the OPAC, view the bibliographic detail page for any title. If you
   used a dummy URL for the js preference you should see an error in the
   console about the file not being found. This confirms that the
   template logic is working. If you used a working Babeltheque URL then
   the corresponding content should load.
 - Return to system preferences and remove the URL from the
   "Babeltheque_url_js" preference.
 - Return to the bibliographic detail page in the OPAC and confirm that
   there is no warning in the console about "'src' attribute of <script>
   element is empty."

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
rmain2205
Owen Leonard 2 months ago
committed by Fridolin Somers
parent
commit
4078720198
  1. 2
      koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

@ -1076,7 +1076,7 @@
<script src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
[% END %]
[% IF ( Babeltheque ) %]
[% IF ( Babeltheque && Babeltheque_url_js ) %]
<script src="[% Babeltheque_url_js | html %]"></script>
[% END %]
</div> <!-- / .row -->

Loading…
Cancel
Save