Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21500: Remove warnings in rotating collections

Browse source 
To test:
- Go to Tools > Rotating collections
=> FAIL: Some warinings on the logs
- Apply this patch
- Reload page
=> SUCCESS: No warinings
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Tomás Cohen Arazi 2018-10-04 14:08:32 -03:00 committed by Nick Clemens
parent 074c329774
commit 40803d3035
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
rotating_collections/addItems.pl
View file

@ -41,7 +41,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
}
);
if ( $query->param('action') eq 'addItem' ) {
if ( defined $query->param('action') and
$query->param('action') eq 'addItem' ) {
## Add the given item to the collection
my $colId = $query->param('colId');
my $barcode = $query->param('barcode');
@ -91,7 +92,7 @@ if ( $query->param('action') eq 'addItem' ) {
}
my ( $colId, $colTitle, $colDescription, $colBranchcode ) =
GetCollection( $query->param('colId') );
GetCollection( scalar $query->param('colId') );
my $collectionItems = GetItemsInCollection($colId);
if ($collectionItems) {
$template->param( collectionItemsLoop => $collectionItems );