Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Fix for Bug 5443, Inaccurate highlighting of fields in patron update email

Browse source 
- email was incorrectly named emailaddress
- string processing was being done to address and B_address
  which didn't seem to be serving a purpose

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Owen Leonard 2010-12-10 15:32:20 +00:00 committed by Chris Cormack
parent 9a15aa4514
commit 4095d45eaf
2 changed files with 3 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl
View file

@ -37,7 +37,7 @@
<li><label for="mobile">Mobile Phone:</label> <input id="mobile" type="text" value="<!-- TMPL_VAR name="mobile" -->" name="mobile" /></li>
<li><label for="phonepro">Work phone:</label> <input id="phonepro" type="text" value="<!-- TMPL_VAR name="phonepro" -->" name="phonepro" /></li>
<li><label for="fax">Fax:</label> <input id="fax" type="text" value="<!-- TMPL_VAR name="fax" -->" name="fax" /></li>
<li><label for="emailaddress">Email:</label> <input id="emailaddress" type="text" value="<!-- TMPL_VAR name="email" -->" name="emailaddress" /></li>
<li><label for="emailaddress">Email:</label> <input id="emailaddress" type="text" value="<!-- TMPL_VAR name="email" -->" name="email" /></li>
<li><label for="emailpro">Work Email:</label> <input id="emailpro" type="text" value="<!-- TMPL_VAR name="emailpro" -->" name="emailpro" /></li>
</ol>
</fieldset>

14
opac/opac-userupdate.pl
View file

@ -53,7 +53,7 @@ my $lib = GetBranchDetail($borr->{'branchcode'});
# handle the new information....
# collect the form values and send an email.
my @fields = (
'surname','firstname','othernames','streetnumber','address','address2','city','zipcode','country','phone','mobile','fax','phonepro', 'emailaddress','emailpro','B_streetnumber','B_address','B_address2','B_city','B_zipcode','B_country','B_phone','B_email','dateofbirth','sex'
'surname','firstname','othernames','streetnumber','address','address2','city','zipcode','country','phone','mobile','fax','phonepro', 'email','emailpro','B_streetnumber','B_address','B_address2','B_city','B_zipcode','B_country','B_phone','B_email','dateofbirth','sex'
);
my $update;
my $updateemailaddress = $lib->{'branchemail'};
@ -84,7 +84,7 @@ if ( $query->param('modify') ) {
# get all the fields:
my $message = <<"EOF";
Borrower $borr->{'cardnumber'}
Patron $borr->{'cardnumber'}
has requested to change her/his personal details.
Please check these new details and make the changes:
@ -104,16 +104,6 @@ EOF
$borrowerfield = $borr->{$field};
}
# reconstruct the address
if($field eq "address") {
$borrowerfield = "$streetnumber $address, $address2";
}
# reconstruct the alternate address
if($field eq "B_address") {
$borrowerfield = "$B_streetnumber $B_address, $B_address2";
}
if($field eq "dateofbirth") {
$borrowerfield = format_date( $borr->{'dateofbirth'} ) || '';
}