Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber

Browse source 
C4::Circ::CheckIfIssuedToPatron called
  $items = GetItemsByBiblioitemnumber($biblionumber);
But if biblionumber != biblioitemnumber, the items retrieved were not
the good ones!

Test plan:
Make your Auto increment values for biblio and biblioitems differs
Launch the tests:
    prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t

Before this patch, they did not pass.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2015-04-22 16:05:41 +02:00 committed by Tomas Cohen Arazi
parent 5ee69d78dc
commit 40e4722a95
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
C4/Circulation.pm
View file

@ -3808,12 +3808,15 @@ sub TransferSlip {
sub CheckIfIssuedToPatron { sub CheckIfIssuedToPatron {
my ($borrowernumber, $biblionumber) = @_; my ($borrowernumber, $biblionumber) = @_;
my $items = GetItemsByBiblioitemnumber($biblionumber); my $dbh = C4::Context->dbh;
my $query = q|
foreach my $item (@{$items}) { SELECT COUNT(*) FROM issues
return 1 if ($item->{borrowernumber} && $item->{borrowernumber} eq $borrowernumber); LEFT JOIN items ON items.itemnumber = issues.itemnumber
} WHERE items.biblionumber = ?
AND issues.borrowernumber = ?
|;
my $is_issued = $dbh->selectrow_array($query, {}, $biblionumber, $borrowernumber );
return 1 if $is_issued;
return; return;
} }