Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34478: Manual fix - serials/subscription-add.pl

Browse source 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2024-02-23 13:12:02 +01:00
parent 647d59b449
commit 41704bdb16
Signed by: jonathan.druart
GPG key ID: A085E712BEF0E0F0
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
serials/subscription-add.pl
View file

@ -46,7 +46,7 @@ my $sub_length;
# Permission needed if it is a modification : edit_subscription
# Permission needed otherwise (nothing or dup) : create_subscription
my $permission =
( $op eq 'cud-modify' || $op eq 'cud-modsubscription' ) ? "edit_subscription" : "create_subscription";
( $op eq 'modify' || $op eq 'cud-modsubscription' ) ? "edit_subscription" : "create_subscription";
our ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "serials/subscription-add.tt",
@ -66,7 +66,7 @@ my $mana_url = C4::Context->config('mana_config');
$template->param( 'mana_url' => $mana_url );
my $subscriptionid = $query->param('subscriptionid');
if ($op eq 'cud-modify' || $op eq 'dup' || $op eq 'cud-modsubscription') {
if ($op eq 'modify' || $op eq 'dup' || $op eq 'cud-modsubscription') {
$subs = GetSubscription($subscriptionid);
@ -74,7 +74,7 @@ if ($op eq 'cud-modify' || $op eq 'dup' || $op eq 'cud-modsubscription') {
unless $subs;
## FIXME : Check rights to edit if mod. Could/Should display an error message.
if ($subs->{'cannotedit'} && $op eq 'cud-modify'){
if ($subs->{'cannotedit'} && $op eq 'modify'){
carp "Attempt to modify subscription $subscriptionid by ".C4::Context->userenv->{'id'}." not allowed";
print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
}
@ -84,7 +84,7 @@ if ($op eq 'cud-modify' || $op eq 'dup' || $op eq 'cud-modsubscription') {
}
my $nextexpected = GetNextExpected($subscriptionid);
$nextexpected->{'isfirstissue'} = $nextexpected->{planneddate} eq $firstissuedate ;
$subs->{nextacquidate} = $nextexpected->{planneddate} if($op eq 'cud-modify');
$subs->{nextacquidate} = $nextexpected->{planneddate} if($op eq 'modify');
unless($op eq 'cud-modsubscription') {
foreach my $length_unit (qw(numberlength weeklength monthlength)) {
if ($subs->{$length_unit}) {
@ -99,11 +99,11 @@ if ($op eq 'cud-modify' || $op eq 'dup' || $op eq 'cud-modsubscription') {
$op => 1,
"subtype_$sub_on" => 1,
sublength =>$sub_length,
history => ($op eq 'cud-modify'),
history => ($op eq 'modify'),
firstacquiyear => substr($firstissuedate,0,4),
);
if($op eq 'cud-modify') {
if($op eq 'modify') {
my ($serials_number) = GetSerials($subscriptionid);
if($serials_number > 1) {
$template->param(more_than_one_serial => 1);
@ -178,7 +178,7 @@ if ($op eq 'cud-addsubscription') {
subtype => $sub_on,
);
if ( $op ne 'cud-modsubscription' && $op ne 'dup' && $op ne 'cud-modify' ) {
if ( $op ne 'cud-modsubscription' && $op ne 'dup' && $op ne 'modify' ) {
my $letters = get_letter_loop();
$template->param( letterloop => $letters );
}