Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 14694 [QA Followup] - Fix unit tests

Browse source 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
Kyle Hall 2015-10-22 08:12:10 -04:00 committed by Brendan A Gallagher
parent f2dd831542
commit 417f7c54e1
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
t/db_dependent/DecreaseLoanHighHolds.t
View file

@ -64,7 +64,7 @@ for my $i ( 1 .. 10 ) {
push( @items, $item );
}
for my $i ( 0 .. 4 ) {
for my $i ( 0 .. 5 ) {
my $patron = $patrons[$i];
my $hold = Koha::Hold->new(
{
@ -92,8 +92,8 @@ my $item_hr = { itemnumber => $item->id, biblionumber => $biblio->id, homebranch
my $patron_hr = { borrower => $patron->id, branchcode => 'MPL' };
my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 1, "Should exceed threshold" );
is( $data->{outstanding}, 5, "Should have 5 outstanding holds" );
is( $data->{exceeded}, 1, "Static mode should exceed threshold" );
is( $data->{outstanding}, 6, "Should have 5 outstanding holds" );
is( $data->{duration}, 1, "Should have duration of 1" );
is( ref( $data->{due_date} ), 'DateTime', "due_date should be a DateTime object" );
@ -113,39 +113,39 @@ for my $i ( 5 .. 10 ) {
}
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 1, "Should exceed threshold" );
is( $data->{exceeded}, 1, "Should exceed threshold of 1" );
C4::Context->set_preference( 'decreaseLoanHighHoldsValue', 2 );
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 0, "Should not exceed threshold" );
is( $data->{exceeded}, 0, "Should not exceed threshold of 2" );
my $unholdable = pop(@items);
$unholdable->damaged(-1);
$unholdable->store();
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 1, "Should exceed threshold" );
is( $data->{exceeded}, 1, "Should exceed threshold with one damanged item" );
$unholdable->damaged(0);
$unholdable->itemlost(-1);
$unholdable->store();
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 1, "Should exceed threshold" );
is( $data->{exceeded}, 1, "Should exceed threshold with one lost item" );
$unholdable->itemlost(0);
$unholdable->notforloan(-1);
$unholdable->store();
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 1, "Should exceed threshold" );
is( $data->{exceeded}, 1, "Should exceed threshold wiht one notforloan item" );
$unholdable->notforloan(0);
$unholdable->withdrawn(-1);
$unholdable->store();
$data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr );
is( $data->{exceeded}, 1, "Should exceed threshold" );
is( $data->{exceeded}, 1, "Should exceed threshold with one withdrawn item" );
$schema->storage->txn_rollback();
1;