Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32739: Unit tests

Browse source 
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Tomás Cohen Arazi 2023-07-17 15:48:09 -03:00
parent 4485963f5d
commit 419d1d4fe9
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 96 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

158
t/db_dependent/api/v1/password_validation.t
View file

@ -18,7 +18,7 @@
use Modern::Perl;
use Test::More tests => 6;
use Test::More tests => 4;
use Test::Mojo;
use t::lib::TestBuilder;
@ -45,24 +45,6 @@ my $password = 'thePassword123';
$librarian->set_password( { password => $password, skip_validation => 1 } );
my $userid = $librarian->userid;
subtest 'password validation - success' => sub {
plan tests => 3;
$schema->storage->txn_begin;
my $json = {
"userid" => $userid,
"password" => $password,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(204)
->content_is(q{});
$schema->storage->txn_rollback;
};
subtest 'password validation - account lock out' => sub {
plan tests => 6;
@ -72,8 +54,8 @@ subtest 'password validation - account lock out' => sub {
t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 1 );
my $json = {
"userid" => $userid,
"password" => "bad",
identifier => $userid,
password => "bad",
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
@ -89,43 +71,6 @@ subtest 'password validation - account lock out' => sub {
$schema->storage->txn_rollback;
};
subtest 'password validation - bad userid' => sub {
plan tests => 3;
$schema->storage->txn_begin;
my $json = {
"userid" => '1234567890abcdefghijklmnopqrstuvwxyz@koha-community.org',
"password" => $password,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(400)
->json_is({ error => q{Validation failed} });
$schema->storage->txn_rollback;
};
subtest 'password validation - bad password' => sub {
plan tests => 3;
$schema->storage->txn_begin;
my $json = {
"userid" => $userid,
"password" => 'bad',
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(400)
->json_is({ error => q{Validation failed} });
$schema->storage->txn_rollback;
};
subtest 'password validation - unauthorized user' => sub {
plan tests => 3;
@ -143,8 +88,8 @@ subtest 'password validation - unauthorized user' => sub {
my $userid = $patron->userid;
my $json = {
"userid" => $userid,
"password" => "test",
identifier => $userid,
password => "test",
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
@ -160,8 +105,8 @@ subtest 'password validation - unauthenticated user' => sub {
$schema->storage->txn_begin;
my $json = {
"userid" => "banana",
"password" => "test",
identifier => "banana",
password => "test",
};
$t->post_ok( "/api/v1/auth/password/validation" => json => $json )
@ -171,4 +116,93 @@ subtest 'password validation - unauthenticated user' => sub {
$schema->storage->txn_rollback;
};
subtest 'Password validation - authorized requests tests' => sub {
plan tests => 24;
$schema->storage->txn_begin;
# generate a random unused userid
my $patron_to_delete = $builder->build_object( { class => 'Koha::Patrons' } );
my $deleted_userid = $patron_to_delete->userid;
my $deleted_cardnumber = $patron_to_delete->cardnumber;
$patron_to_delete->delete;
my $json = {
identifier => $librarian->userid,
password => $password,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(204, 'Validating using `cardnumber` works')
->content_is(q{});
$json = {
identifier => $librarian->cardnumber,
password => $password,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(204, 'Validating using `cardnumber` works')
->content_is(q{});
$json = {
identifier => $deleted_cardnumber,
password => $password,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(400, 'Validating using and invalid identifier fails')
->json_is({ error => 'Validation failed' });
$json = {
identifier => $deleted_userid,
password => $password,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(400, 'Validating using and invalid identifier fails')
->json_is({ error => 'Validation failed' });
$json = {
password => $password,
userid => $deleted_userid,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(400, 'Validating using and invalid userid fails')
->json_is({ error => 'Validation failed' });
$json = {
password => $password,
userid => $userid,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(204, 'Validating using the `userid` attribute works')
->content_is(q{});
$json = {
password => $password,
userid => $librarian->cardnumber,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is( 400, 'Validating using a cardnumber as userid fails' )->json_is( { error => 'Validation failed' } );
$json = {
identifier => $userid,
password => $password,
userid => $userid,
};
$t->post_ok( "//$userid:$password@/api/v1/auth/password/validation" => json => $json )
->status_is(400, 'Passing both parameters forbidden')
->json_is({ error => 'Bad request. Only one identifier attribute can be passed.' });
$schema->storage->txn_rollback;
};
$schema->storage->txn_rollback;