We should remove the debug statements or use Koha::Logger when we want
to keep it.
Test plan:
Confirm that occurrences of remaining occurrences of DEBUG need to be
kept (historical scripts for instance)
Confirm that the occurrences removed by this patch can be removed
Confirm that the occurrences replaced by Koha::Logger are correct
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Looks good to me, noting a few minor points on BZ.
JD amended patch: replace "warn #Finished" with "#warn Finished", and
put the statement on a single line
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
$debugandwarn"User CAS authenticated as: $userid";
# we should store the CAS ticekt too, we need this for single logout https://apereo.github.io/cas/4.2.x/protocol/CAS-Protocol-Specification.html#233-single-logout
@ -134,13 +131,14 @@ sub checkpw_cas {
}
# If we reach this point, then the user is a valid CAS user, but not a Koha user
$debugandwarn"User $userid is not a valid Koha user";
Koha::Logger->get->info("User $userid is not a valid Koha user");
}else{
$debugandwarn"Problem when validating ticket : $ticket";
# we should store the CAS ticket too, we need this for single logout https://apereo.github.io/cas/4.2.x/protocol/CAS-Protocol-Specification.html#233-single-logout
@ -186,10 +179,10 @@ sub check_api_auth_cas {
}
# If we reach this point, then the user is a valid CAS user, but not a Koha user
$debugandwarn"User $userid is not a valid Koha user";
Koha::Logger->get->info("User $userid is not a valid Koha user");
# $line =~ m/^.*(\s\b.*\b\s*|\s&|\<\b.*\b\>)$/; # original regexp... can be removed after dev stage is over
$line=~m/^.*(\s.*\s*|\s&|\<.*\>)$/;
warnsprintf('Line wrap failed. DEBUG INFO: Data: \'%s\'\n Method: C4::Patroncards->draw_text Additional Information: Line wrap regexp failed. (Please file in this information in a bug report at http://bugs.koha-community.org',$line)andlastWRAP_LINESif!$1;
$trim=$1.$trim;
#Sanitize the input into this regular expression so regex metacharacters are escaped as literal values (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429)
