Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33967: Fix SetEnv middleware to preserve $env integrity

Browse source 
This patch fixes the Koha::Middleware::SetEnv, so that it
preserves the referential integrity of the $env hash
reference as it passes through the pre-process and post-process
stages of middleware wrapped around the core Koha Plack application.

Test plan:
0a. Apply the patch
0b. vi /etc/koha/sites/kohadev/koha-conf.xml
0c. Uncomment "koha_trusted_proxies"
0d. Add "172.0.0.0/8" to the end of the "koha_trusted_proxies"
0e. koha-plack --restart kohadev
1. vi /etc/apache2/sites-enabled/kohadev.conf
2. Add the following to the OPAC virtualhost:
SetEnv OVERRIDE_SYSPREF_LibraryName "The Best, Truly the Best, Koha Library"
RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName The Best\, Truly the Best\, Koha Library"
RequestHeader add X-Forwarded-For "192.168.100.100"
3. service apache2 restart
4. tail -f /var/log/koha/kohadev/plack.log
5. Go to http://localhost:8080/
6. Note that the plack.log lists 192.168.100.100 as the client IP address
7. Note that the title of the OPAC webpage is
"The Best, Truly the Best, Koha Library Library catalog"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
David Cook 2023-06-09 03:59:28 +00:00 committed by Tomas Cohen Arazi
parent cd24b5a37f
commit 42823da209
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Koha/Middleware/SetEnv.pm
View file

@ -96,11 +96,12 @@ sub call {
}
} @setenv_headers;
# Finally, everything is shoved into the $env.
$env = {
%$env,
%setenvs
};
#Add the environmental variables to the $env hashref which travels between middlewares
#NOTE: It's very important that this $env keeps the same reference address so that
#all middlewares act correctly
foreach my $key ( keys %setenvs ) {
$env->{$key} = $setenvs{$key};
}
return $self->app->($env);
}