Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31798: (follow-up) Handle all values of autoBarcode

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2023-05-03 12:08:46 -03:00 committed by Tomas Cohen Arazi
parent 141c7cdf1a
commit 42c221cf1f
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 67 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

72
Koha/REST/V1/Biblios.pm
View file

@ -20,6 +20,7 @@ use Modern::Perl;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
use Koha::Biblios; use Koha::Biblios;
use Koha::DateUtils;
use Koha::Ratings; use Koha::Ratings;
use Koha::RecordProcessor; use Koha::RecordProcessor;
use C4::Biblio qw( DelBiblio AddBiblio ModBiblio ); use C4::Biblio qw( DelBiblio AddBiblio ModBiblio );
@ -291,7 +292,7 @@ sub add_item {
try { try {
my $biblio_id = $c->validation->param('biblio_id'); my $biblio_id = $c->validation->param('biblio_id');
my $biblio = Koha::Biblios->find( $biblio_id ); my $biblio = Koha::Biblios->find( $biblio_id );
unless ($biblio) { unless ($biblio) {
return $c->render( return $c->render(
@ -309,15 +310,76 @@ sub add_item {
my $item = Koha::Item->new_from_api($body); my $item = Koha::Item->new_from_api($body);
if ( ! defined $item->barcode && C4::Context->preference('autoBarcode') eq 'incremental' ) { if ( !defined $item->barcode ) {
my ( $barcode ) = C4::Barcodes::ValueBuilder::incremental::get_barcode;
$item->barcode($barcode); # FIXME This should be moved to Koha::Item->store
my $autoBarcode = C4::Context->preference('autoBarcode');
my $barcode = '';
if ( !$autoBarcode || $autoBarcode eq 'OFF' ) {
#We do nothing
}
elsif ( $autoBarcode eq 'incremental' ) {
($barcode) =
C4::Barcodes::ValueBuilder::incremental::get_barcode;
}
elsif ( $autoBarcode eq 'annual' ) {
my $year = Koha::DateUtils::dt_from_string()->year();
($barcode) =
C4::Barcodes::ValueBuilder::annual::get_barcode(
{ year => $year } );
}
elsif ( $autoBarcode eq 'hbyymmincr' ) {
# Generates a barcode where
# hb = home branch Code,
# yymm = year/month catalogued,
# incr = incremental number,
# reset yearly -fbcit
my $now = Koha::DateUtils::dt_from_string();
my $year = $now->year();
my $month = $now->month();
my $homebranch = $item->homebranch // '';
($barcode) =
C4::Barcodes::ValueBuilder::hbyymmincr::get_barcode(
{ year => $year, mon => $month } );
$barcode = $homebranch . $barcode;
}
elsif ( $autoBarcode eq 'EAN13' ) {
# not the best, two catalogers could add the same
# barcode easily this way :/
my $query = "select max(abs(barcode)) from items";
my $dbh = C4::Context->dbh;
my $sth = $dbh->prepare($query);
$sth->execute();
my $nextnum;
while ( my ($last) = $sth->fetchrow_array ) {
$nextnum = $last;
}
my $ean = CheckDigits('ean');
if ( $ean->is_valid($nextnum) ) {
my $next = $ean->basenumber($nextnum) + 1;
$nextnum = $ean->complete($next);
$nextnum =
'0' x ( 13 - length($nextnum) ) . $nextnum; # pad zeros
}
else {
warn "ERROR: invalid EAN-13 $nextnum, using increment";
$nextnum++;
}
$barcode = $nextnum;
}
else {
warn "ERROR: unknown autoBarcode: $autoBarcode";
}
$item->barcode($barcode) if $barcode;
} }
$item->store->discard_changes; $item->store->discard_changes;
$c->render( $c->render(
status => 201, status => 201,
openapi => $item->to_api openapi => $item->to_api
); );
} }