Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25872: Fix scoping of $limits

Browse source 
The code in build_query_compat contained a 'my' in the assigning of limits for the search in a conditional

This meant the limits were being set correctly during the conditional, but we blanked when passed to the rest
of the code. The effect was that the searches worked, however, the template params to repeat the search were
incomplete.

Removing the my ensures the same limits are applied during search and on re-sorting

To test:
1 - Enable Elasticsearch
2 - On OPAC perform advanced search, selecting only an itype, ccode, or LOC limit
3 - Attempt to sort results
4 - You are returned to Advanced search
5 - Apply patch
6 - Repeat
7 - It sorts!

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-08-13 12:56:33 +00:00 committed by Jonathan Druart
parent 2f3a886f7b
commit 43dc505a52
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
View file

@ -176,7 +176,7 @@ sub build_query_compat {
} else {
my @sort_params = $self->_convert_sort_fields(@$sort_by);
my @index_params = $self->_convert_index_fields(@$indexes);
my $limits = $self->_fix_limit_special_cases($orig_limits);
$limits = $self->_fix_limit_special_cases($orig_limits);
if ( $params->{suppress} ) { push @$limits, "suppress:false"; }
# Merge the indexes in with the search terms and the operands so that
# each search thing is a handy unit.