From 43dda643817b6bb83c27fd257532d2b4a2593592 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 8 Nov 2016 09:46:15 +0000
Subject: [PATCH] Bug 17578: GetMemberDetails - Remove reservefee

Same as other patches, reservefee is only used in opac-reserve.pl

Test plan;
Set reserve fee for a patron category
Place a hold at the OPAC with one of these patrons.
You must get a message about the reserve fee.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 C4/Members.pm        | 2 --
 opac/opac-reserve.pl | 5 +++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/C4/Members.pm b/C4/Members.pm
index b64ccb8741..9a8d5fc1d1 100644
--- a/C4/Members.pm
+++ b/C4/Members.pm
@@ -146,7 +146,6 @@ sub GetMemberDetails {
             SELECT borrowers.*,
                    category_type,
                    categories.description,
-                   reservefee,
                    enrolmentperiod
             FROM borrowers
             LEFT JOIN categories ON borrowers.categorycode=categories.categorycode
@@ -159,7 +158,6 @@ sub GetMemberDetails {
             SELECT borrowers.*,
                    category_type,
                    categories.description,
-                   reservefee,
                    enrolmentperiod
             FROM borrowers
             LEFT JOIN categories ON borrowers.categorycode = categories.categorycode
diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
index a725730a1a..7363236408 100755
--- a/opac/opac-reserve.pl
+++ b/opac/opac-reserve.pl
@@ -85,8 +85,9 @@ if ( $patron->category->effective_BlockExpiredPatronOpacActions ) {
 }
 
 # Pass through any reserve charge
-if ($borr->{reservefee} > 0){
-    $template->param( RESERVE_CHARGE => sprintf("%.2f",$borr->{reservefee}));
+my $reservefee = $patron->category->reservefee;
+if ( $reservefee > 0){
+    $template->param( RESERVE_CHARGE => sprintf("%.2f",$reservefee));
 }
 
 my $itemTypes = GetItemTypes();