Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32302: Hide "ISBN" label when no ISBN data when sending list

Browse source 
There is a logic mistake in the opac-sendshelf.tt template where
we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when
we should really be testing if the arrayref returned by "ISBN" is
empty or not, since that "ISBN" key always exists and contains at least
an empty arrayref.

Test plan:
1. Apply patch and restart your Koha Starman
2. Create a public list containing records with 020 MARC fields and
records without 020 MARC fields
3. View the list in the OPAC
4. Click "Send list" and email it to yourself
5. Note that only records with 020 MARC fields with show "ISBN:"
in the email output

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
David Cook 2022-12-01 09:52:55 +11:00 committed by Tomas Cohen Arazi
parent d918672891
commit 44366c0985
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt
View file

@ -58,7 +58,7 @@ Your list : [% shelfname | $raw %]
</span><br/>
[% END %]
[% IF ( BIBLIO_RESULT.ISBN ) %]
[% IF ( BIBLIO_RESULT.ISBN.size > 0 ) %]
<span>
ISBN: [% FOREACH isbn IN BIBLIO_RESULT.ISBN %]
[% isbn | $raw %]